ci: bump pinned Ginkgo CLI to v2.23.4 to match go.mod#696
Open
Copilot wants to merge 1 commit into
Open
Conversation
Copilot
AI
changed the title
[WIP] Fix Ginkgo CLI/runtime version mismatch causing AfterSuite timeout
ci: bump pinned Ginkgo CLI to v2.23.4 to match go.mod
May 6, 2026
Yetkin Timocin (ytimocin)
force-pushed
the
copilot/fix-ginkgo-cli-runtime-mismatch
branch
from
b0bfb41 to
3c6f94f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Yetkin Timocin (ytimocin)
approved these changes
May 6, 2026
Yetkin Timocin (ytimocin)
force-pushed
the
copilot/fix-ginkgo-cli-runtime-mismatch
branch
from
3c6f94f to
1b3dccb
Compare
Agent-Logs-Url: https://github.com/kubefleet-dev/kubefleet/sessions/ee40189d-043f-4727-ad2e-239b05bbbc09 Co-authored-by: ytimocin <5220939+ytimocin@users.noreply.github.com>
Yetkin Timocin (ytimocin)
force-pushed
the
copilot/fix-ginkgo-cli-runtime-mismatch
branch
from
1b3dccb to
2698f1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every PR triggering
unit-and-integration-testswas failing inpkg/controllers/workapplierAfterSuite teardown because Ginkgo detected a CLI/runtime version mismatch (v2.19.1CLI vsv2.23.4runtime fromgo.mod), causing a 30s grace-period timeout despite all 290 specs passing.Changes
.github/workflows/ci.yml— bump Ginkgo CLI install inunit-and-integration-testsjob:v2.19.1→v2.23.4.github/workflows/upgrade.yml— same bump across all three job steps that install the Ginkgo CLIAll workflow jobs now install the CLI version that matches
go.mod.