Skip to content

Update kserve/kserve manifests from v0.18.0#3406

Merged
google-oss-prow[bot] merged 9 commits into
kubeflow:masterfrom
christian-heusel:synchronize-kserve-manifests-release-0.17
May 12, 2026
Merged

Update kserve/kserve manifests from v0.18.0#3406
google-oss-prow[bot] merged 9 commits into
kubeflow:masterfrom
christian-heusel:synchronize-kserve-manifests-release-0.17

Conversation

@christian-heusel
Copy link
Copy Markdown
Contributor

@christian-heusel christian-heusel commented Mar 19, 2026

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Update the manifests for kserve from 0.16.0 to v0.18.0

🚧 Remaining ToDo's:

📦 Dependencies

none

🐛 Related Issues

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Copilot AI review requested due to automatic review settings March 19, 2026 09:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Kubeflow manifests tracking for KServe to v0.17.0, accounting for the fact that the original v0.17.0 tag did not include the required install artifacts.

Changes:

  • Bumps the KServe synchronization script reference from v0.16.0 to v0.17.0.
  • Updates the root README component table entry for KServe to v0.17.0 and links to the release branch path containing the install files.

Reviewed changes

Copilot reviewed 2 out of 6 changed files in this pull request and generated 3 comments.

File Description
scripts/synchronize-kserve-kserve-manifests.sh Updates the git ref used by the sync script to target KServe v0.17.0.
README.md Updates the KServe row to reflect v0.17.0 and links to the install directory on the release branch.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread scripts/synchronize-kserve-kserve-manifests.sh
Comment thread README.md Outdated
Comment thread README.md Outdated
@abdullahpathan22
Copy link
Copy Markdown
Contributor

abdullahpathan22 commented Mar 23, 2026

@christian-heusel/ @juliusvonkohout I noticed the llmisvc-manager-rolebinding deletion step in the ToDo list is currently undocumented. I opened a companion PR #3420 that adds upgrade notes covering this breaking change, the v0.17.0 tag issue, and the Certificate SAN fix. Happy to adjust based on your feedback.

@christian-heusel christian-heusel force-pushed the synchronize-kserve-manifests-release-0.17 branch from fa00f5a to 01b9dab Compare March 23, 2026 13:05
@juliusvonkohout
Copy link
Copy Markdown
Member

Please rebase to master

@christian-heusel christian-heusel force-pushed the synchronize-kserve-manifests-release-0.17 branch 3 times, most recently from 49816e7 to 2d01eef Compare March 27, 2026 19:34
@christian-heusel christian-heusel marked this pull request as ready for review March 27, 2026 19:49
@christian-heusel
Copy link
Copy Markdown
Contributor Author

/hold

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Kubeflow Manifests KServe component to align with KServe v0.17.0 (synced from release-0.17 due to the upstream tag missing install artifacts), and applies Kubeflow-specific fixes to keep the deployment functional in the kubeflow namespace.

Changes:

  • Update the KServe synchronization script/version metadata for the v0.17.0 sync workflow.
  • Add/adjust Kustomize patches to fix cert-manager CA injection references and webhook certificate SANs for kubeflow namespace installs.
  • Refresh KServe cluster resources (runtime images, new runtimes, and updated LLM-related templates/configs).

Reviewed changes

Copilot reviewed 3 out of 7 changed files in this pull request and generated 8 comments.

File Description
scripts/synchronize-kserve-kserve-manifests.sh Updates sync inputs/versioning for the v0.17.0 KServe manifests sync.
applications/kserve/kserve/kustomization.yaml Adds patches to fix cert-manager injection + certificate SAN issues and updates LLM-related patch targeting.
applications/kserve/kserve/kserve-cluster-resources.yaml Updates runtime images/annotations and substantially revises LLM templates and related configs.
README.md Updates the KServe “Upstream Revision” entry to v0.17.0.

Comment thread applications/kserve/kserve/kserve-cluster-resources.yaml
Comment thread applications/kserve/kserve/kserve-cluster-resources.yaml
Comment thread applications/kserve/kserve/kserve-cluster-resources.yaml
Comment thread applications/kserve/kserve/kserve-cluster-resources.yaml
Comment thread README.md Outdated
Comment thread scripts/synchronize-kserve-kserve-manifests.sh Outdated
Comment thread applications/kserve/kserve/kserve-cluster-resources.yaml
Comment thread applications/kserve/kserve/kserve-cluster-resources.yaml
Comment thread applications/kserve/kserve/kustomization.yaml Outdated
@tarekabouzeid
Copy link
Copy Markdown
Member

@christian-heusel @vrajjbhatt Got confirmation from Kserve to use 0.18.0 instead. Please create another PR for that version instead.

@christian-heusel christian-heusel force-pushed the synchronize-kserve-manifests-release-0.17 branch from 2d01eef to a1c1edd Compare May 6, 2026 17:48
@christian-heusel christian-heusel changed the title Update kserve/kserve manifests from v0.17.0 Update kserve/kserve manifests from v0.18.0 May 6, 2026
@christian-heusel christian-heusel marked this pull request as draft May 6, 2026 17:48
@christian-heusel christian-heusel force-pushed the synchronize-kserve-manifests-release-0.17 branch from 9d29df1 to d7a542e Compare May 6, 2026 22:22
@christian-heusel christian-heusel requested a review from Copilot May 6, 2026 23:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 16 changed files in this pull request and generated 11 comments.

Comment thread applications/kserve/kserve/kustomization.yaml Outdated
Comment thread applications/kserve/kserve/llmisvc-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/llmisvc-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/llmisvc-autoscaling-keda-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/llmisvc-autoscaling-keda-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/llmisvc-autoscaling-hpa-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/kserve-standard-mode-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/kserve-knative-mode-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/keda-dependency-install.sh Outdated
Comment thread scripts/synchronize-kserve-kserve-manifests.sh
@christian-heusel christian-heusel marked this pull request as ready for review May 6, 2026 23:23
@google-oss-prow google-oss-prow Bot requested a review from kimwnasptd May 6, 2026 23:23
Comment thread applications/kserve/kserve/kustomization.yaml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 16 changed files in this pull request and generated 10 comments.

Comment thread scripts/synchronize-kserve-kserve-manifests.sh
Comment thread applications/kserve/kserve/kustomization.yaml Outdated
Comment thread applications/kserve/kserve/kustomization.yaml Outdated
Comment thread applications/kserve/kserve/llmisvc-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/llmisvc-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/llmisvc-autoscaling-keda-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/llmisvc-autoscaling-hpa-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/kserve-standard-mode-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/kserve-knative-mode-dependency-install.sh Outdated
Comment thread applications/kserve/kserve/keda-dependency-install.sh Outdated
@tarekabouzeid
Copy link
Copy Markdown
Member

@christian-heusel Thanks so much for this work, can you rebase and look into applications/kserve/kserve/kustomization.yaml

christian-heusel and others added 9 commits May 11, 2026 10:49
There are a few specialties regarding this release as the initial
v0.17.0 tag did not contain the needed install files, see the linked
issue for more details. This is also the reason that the manifests were
synced from the `release-v0.17` branch manually instead of using the tag
as we normally do.

Additionally the sync came with a bunch of script which I did not
include into the changes as they were only scripts:

- `applications/kserve/kserve/keda-dependency-install.sh`
- `applications/kserve/kserve/kserve-knative-mode-dependency-install.sh`
- `applications/kserve/kserve/kserve-knative-mode-full-install-with-manifests.sh`
- `applications/kserve/kserve/kserve-standard-mode-dependency-install.sh`
- `applications/kserve/kserve/kserve-standard-mode-full-install-with-manifests.sh`
- `applications/kserve/kserve/llmisvc-dependency-install.sh`
- `applications/kserve/kserve/llmisvc-full-install-with-manifests.sh`

Link: kserve/kserve#5255
Signed-off-by: Christian Heusel <christian@heusel.eu>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Christian Heusel <christian@heusel.eu>
Signed-off-by: Christian Heusel <christian@heusel.eu>
kserve_kubeflow.yaml v0.17.0 introduced a second set of Certificate
resources that still reference the upstream kserve namespace instead of
kubeflow. These duplicates override the correct kubeflow-scoped ones,
causing cert-manager to issue certs with kserve.svc SANs, which results
in TLS verification failures on the webhook server.

Patch all three Certificates (serving-cert, llmisvc-serving-cert,
localmodel-serving-cert) to use the correct kubeflow.svc SANs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Christian Heusel <christian@heusel.eu>
kserve_kubeflow.yaml v0.17.0 hardcodes cert-manager.io/inject-ca-from:
kserve/<cert-name> on all webhook configurations and relevant CRDs, but
the Certificate resources live in the kubeflow namespace. cert-manager's
ca-injector uses this annotation to populate the webhook caBundle, so
with the wrong namespace reference the caBundle is never set and TLS
verification fails with "certificate signed by unknown authority".

Patch all 12 affected resources (1 MutatingWebhookConfiguration, 3 CRDs,
8 ValidatingWebhookConfigurations) to use kubeflow/<cert-name> instead.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Christian Heusel <christian@heusel.eu>
Signed-off-by: Christian Heusel <christian@heusel.eu>
Usually this works automatically, however due to the changes for kserve
v0.17.0 this has to be done manually once.

Signed-off-by: Christian Heusel <christian@heusel.eu>
… targets

Replace 12 individual strategic merge patches with 3 JSON 6902 patches
that use name regex targets, grouping resources by their cert name.

Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Christian Heusel <christian@heusel.eu>
Signed-off-by: Christian Heusel <christian@heusel.eu>
@christian-heusel christian-heusel force-pushed the synchronize-kserve-manifests-release-0.17 branch from 9ec0153 to aa67f78 Compare May 11, 2026 09:25
@tarekabouzeid
Copy link
Copy Markdown
Member

Thanks for your efforts
/lgtm

@juliusvonkohout
Copy link
Copy Markdown
Member

Thank you
/lgtm
/approve

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Copy Markdown
Member

/unhold

@google-oss-prow google-oss-prow Bot merged commit ff06e2d into kubeflow:master May 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants