Skip to content

knative: add eventing security overlay#3419

Merged
google-oss-prow[bot] merged 4 commits into
kubeflow:masterfrom
danish9039:feat/knative-eventing-security-overlays
May 12, 2026
Merged

knative: add eventing security overlay#3419
google-oss-prow[bot] merged 4 commits into
kubeflow:masterfrom
danish9039:feat/knative-eventing-security-overlays

Conversation

@danish9039
Copy link
Copy Markdown
Member

@danish9039 danish9039 commented Mar 22, 2026

Summary

  • add a merged common/knative/knative-eventing/overlays/security overlay
  • add eventing NetworkPolicies and a restricted PSS namespace patch as an opt-in overlay
  • patch request-reply in the overlay so restricted PSS works in-cluster

Copilot AI review requested due to automatic review settings March 22, 2026 21:04
@github-actions
Copy link
Copy Markdown

Welcome to the Kubeflow Manifests Repository

Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community.

Before making more PRs:
Please ensure your PR follows our Contributing Guide.
Please also be aware that many components are synchronizes from upstream via the scripts in /scripts.
So in some cases you have to fix the problem in the upstream repositories first, but you can use a PR against kubeflow/manifests to test the platform integration.

Community Resources:

Thanks again for helping to improve Kubeflow.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an opt-in Knative Eventing “security” overlay to support restricted Pod Security Standards (PSS) installs and documents validation outcomes.

Changes:

  • Added common/knative/knative-eventing/overlays/security with NetworkPolicies, a restricted-PSS namespace label patch, and a request-reply securityContext patch.
  • Added validation documentation artifacts and a canonical validation log entry.
  • Updated .gitignore to ignore repo-root .obsidian/ metadata.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/policy-validation-log.md Adds a canonical validation log entry for the new overlay.
docs/artifacts/INDEX.md Adds an index entry pointing to the new validation artifact and log anchor.
docs/artifacts/2026-03-23-knative-eventing-security-validation.md Adds a detailed validation artifact explaining the PSS issue and overlay behavior.
common/knative/knative-eventing/overlays/security/patches/request-reply-security-context.yaml Adds restricted-PSS-compatible securityContext patch for request-reply.
common/knative/knative-eventing/overlays/security/namespace-patch.yaml Adds restricted PSS enforcement label to the knative-eventing namespace.
common/knative/knative-eventing/overlays/security/kustomization.yaml Wires the overlay resources and patches together.
common/knative/knative-eventing/overlays/security/default-allow-same-namespace.yaml Adds same-namespace-only default ingress policy for Eventing namespace.
common/knative/knative-eventing/overlays/security/allow-webhook-apiserver.yaml Adds webhook ingress allowance (port-based) to keep admission webhooks reachable.
.gitignore Ignores .obsidian/ directory at repo root and normalizes an ignore entry.

@google-oss-prow google-oss-prow Bot added size/M and removed size/L labels Mar 22, 2026
@danish9039 danish9039 force-pushed the feat/knative-eventing-security-overlays branch 2 times, most recently from 02a06a5 to 3e6da07 Compare March 22, 2026 21:15
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039 danish9039 force-pushed the feat/knative-eventing-security-overlays branch from 3e6da07 to 6f44373 Compare March 22, 2026 21:21
@danish9039
Copy link
Copy Markdown
Member Author

@juliusvonkohout

@juliusvonkohout
Copy link
Copy Markdown
Member

Do you have a basic test for knative-eventing ?

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@google-oss-prow google-oss-prow Bot added size/L and removed size/M labels Apr 2, 2026
@danish9039 danish9039 force-pushed the feat/knative-eventing-security-overlays branch from 316b65d to c36f80f Compare April 2, 2026 17:21
@google-oss-prow google-oss-prow Bot added size/M and removed size/L labels Apr 2, 2026
@danish9039 danish9039 marked this pull request as ready for review April 2, 2026 17:23
@danish9039
Copy link
Copy Markdown
Member Author

Do you have a basic test for knative-eventing ?

@juliusvonkohout added tests

Comment thread tests/knative_install.sh Outdated
Comment thread tests/knative_install.sh Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039 danish9039 force-pushed the feat/knative-eventing-security-overlays branch from 045ab6e to b6bea73 Compare April 9, 2026 19:17
@danish9039
Copy link
Copy Markdown
Member Author

danish9039 commented Apr 10, 2026

@juliusvonkohout the current test covers install verification (control-plane pods ready + NetworkPolicy/PSS assertions). Would you like me to extend it with a full functional flow test that has PingSource → Broker (MTChannelBasedBroker/IMC) → Trigger → event-display with actual CloudEvent delivery assertion ?? for that we need a separate test script similar to kserve_test.sh

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Comment thread tests/knative_serving_install.sh
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@google-oss-prow google-oss-prow Bot added size/L and removed size/M labels May 10, 2026
@danish9039
Copy link
Copy Markdown
Member Author

/retest

@danish9039 danish9039 requested a review from Copilot May 10, 2026 10:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

@juliusvonkohout
Copy link
Copy Markdown
Member

Thank you
/lgtm
/approve

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit a1ece32 into kubeflow:master May 12, 2026
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants