chore: address PR feedback

Author: andyatmiami

.github/workflows/ws-e2e-test.yml

@@ -24,10 +24,10 @@ jobs:
         working-directory: testing
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
       - name: Set up Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5
         with:
           go-version: ${{ env.GO_VERSION }}
           cache: false
@@ -39,7 +39,7 @@ jobs:
           echo "cache_key=testing-bin-${{ runner.os }}-go${{ env.GO_VERSION }}-$VERSION_HASH" >> $GITHUB_OUTPUT
 
       - name: Cache testing/bin directory
-        uses: actions/cache@v4
+        uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
         id: cache-testing-bin
         with:
           path: testing/bin

developing/scripts/setup-istio.sh

@@ -9,15 +9,12 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 DEVELOPING_DIR="$(cd "${SCRIPT_DIR}/.." && pwd)"
 LOCALBIN="${DEVELOPING_DIR}/bin"
 
-# Determine istioctl path - prefer LOCALBIN, fallback to PATH
+# Require istioctl from LOCALBIN to ensure a known version
 if [ -f "${LOCALBIN}/istioctl" ]; then
   ISTIOCTL="${LOCALBIN}/istioctl"
-elif command -v istioctl >/dev/null 2>&1; then
-  ISTIOCTL="istioctl"
 else
   echo "ERROR: istioctl is not installed. Please install istioctl first:"
   echo "  cd developing && make istioctl"
-  echo "  or visit: https://istio.io/latest/docs/setup/getting-started/#download"
   exit 1
 fi
 

testing/Makefile

@@ -48,19 +48,19 @@ help: ## Display this help.
 .PHONY: build-controller build-backend build-frontend build-all e2e sanity-check
 
 deploy-controller: kind check-kind-context ## Build and deploy the controller.
-	cd ../workspaces/controller && $(MAKE) docker-build IMG=$(CONTROLLER_IMG)
+	$(MAKE) -C ../workspaces/controller docker-build IMG=$(CONTROLLER_IMG)
 	$(KIND) load docker-image $(CONTROLLER_IMG) --name $(KIND_CLUSTER_NAME)
-	cd ../workspaces/controller && $(MAKE) deploy IMG=$(CONTROLLER_IMG)
+	$(MAKE) -C ../workspaces/controller deploy IMG=$(CONTROLLER_IMG)
 
 deploy-backend: kind check-kind-context ## Build and deploy the backend.
-	cd ../workspaces/backend && $(MAKE) docker-build IMG=$(BACKEND_IMG)
+	$(MAKE) -C ../workspaces/backend docker-build IMG=$(BACKEND_IMG)
 	$(KIND) load docker-image $(BACKEND_IMG) --name $(KIND_CLUSTER_NAME)
-	cd ../workspaces/backend && $(MAKE) deploy IMG=$(BACKEND_IMG)
+	$(MAKE) -C ../workspaces/backend deploy IMG=$(BACKEND_IMG)
 
 deploy-frontend: kind check-kind-context ## Build and deploy the frontend.
-	cd ../workspaces/frontend && $(MAKE) docker-build IMG=$(FRONTEND_IMG)
+	$(MAKE) -C ../workspaces/frontend docker-build IMG=$(FRONTEND_IMG)
 	$(KIND) load docker-image $(FRONTEND_IMG) --name $(KIND_CLUSTER_NAME)
-	cd ../workspaces/frontend && $(MAKE) deploy IMG=$(FRONTEND_IMG)
+	$(MAKE) -C ../workspaces/frontend deploy IMG=$(FRONTEND_IMG)
 
 deploy-all: deploy-controller deploy-backend deploy-frontend ## Deploy all components.
 
@@ -108,7 +108,7 @@ $(ISTIOCTL): $(LOCALBIN)
 
 .PHONY: dependency-hash
 dependency-hash: ## Calculate hash of dependency versions for caching.
-	@echo -e "KIND_VERSION=$(KIND_VERSION)\nISTIOCTL_VERSION=$(ISTIOCTL_VERSION)" | sha256sum | cut -d' ' -f1 | head -c 16
+	@echo -e "KIND_VERSION=$(KIND_VERSION)\nISTIOCTL_VERSION=$(ISTIOCTL_VERSION)" | sha256sum | cut -d' ' -f1
 
 .PHONY: setup-cluster
 setup-cluster: check-kubectl kind istioctl ## Set up a complete kind cluster with cert-manager and Istio.

testing/scripts/sanity-check.sh

@@ -59,7 +59,7 @@ check_http_endpoint() {
   # Wait for port-forward to be ready
   local retries=0
   local max_retries=10
-  while ! curl -s -o /dev/null "http://localhost:${local_port}${probe_path}" 2>/dev/null; do
+  while ! curl --silent --output /dev/null "http://localhost:${local_port}${probe_path}" 2>/dev/null; do
     retries=$((retries + 1))
     if [ ${retries} -ge ${max_retries} ]; then
       echo "✗ ERROR: ${label} endpoint not reachable after ${max_retries} attempts"
@@ -70,7 +70,7 @@ check_http_endpoint() {
 
   # Verify we get a successful response
   local http_code
-  http_code=$(curl -s -o /dev/null -w "%{http_code}" "http://localhost:${local_port}${probe_path}")
+  http_code=$(curl --silent --output /dev/null --write-out "%{http_code}" "http://localhost:${local_port}${probe_path}")
 
   if [ "${http_code}" -ge 200 ] && [ "${http_code}" -lt 400 ]; then
     echo "✓ ${label} HTTP endpoint returned ${http_code}"
@@ -143,7 +143,7 @@ check_gateway_route() {
   # Wait for port-forward to be ready and verify routing
   local retries=0
   local max_retries=10
-  while ! curl -sk -o /dev/null "https://localhost:${local_port}${request_path}" 2>/dev/null; do
+  while ! curl --silent --insecure --output /dev/null "https://localhost:${local_port}${request_path}" 2>/dev/null; do
     retries=$((retries + 1))
     if [ ${retries} -ge ${max_retries} ]; then
       echo "✗ ERROR: ${label} gateway route not reachable after ${max_retries} attempts"
@@ -153,7 +153,7 @@ check_gateway_route() {
   done
 
   local http_code
-  http_code=$(curl -sk -o /dev/null -w "%{http_code}" "https://localhost:${local_port}${request_path}")
+  http_code=$(curl --silent --insecure --output /dev/null --write-out "%{http_code}" "https://localhost:${local_port}${request_path}")
 
   if [ "${http_code}" -ge 200 ] && [ "${http_code}" -lt 400 ]; then
     echo "✓ ${label} gateway route returned ${http_code}"

testing/scripts/setup-istio.sh

@@ -10,15 +10,12 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 TESTING_DIR="$(cd "${SCRIPT_DIR}/.." && pwd)"
 LOCALBIN="${TESTING_DIR}/bin"
 
-# Determine istioctl path - prefer LOCALBIN, fallback to PATH
+# Require istioctl from LOCALBIN to ensure a known version
 if [ -f "${LOCALBIN}/istioctl" ]; then
   ISTIOCTL="${LOCALBIN}/istioctl"
-elif command -v istioctl >/dev/null 2>&1; then
-  ISTIOCTL="istioctl"
 else
   echo "ERROR: istioctl is not installed. Please install istioctl first:"
   echo "  cd testing && make istioctl"
-  echo "  or visit: https://istio.io/latest/docs/setup/getting-started/#download"
   exit 1
 fi