test(e2e): poll MLflow status after retry run failure#13468
Merged
google-oss-prow[bot] merged 1 commit intoJun 1, 2026
Merged
Conversation
Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com>
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
/retest |
nsingla
reviewed
Jun 1, 2026
| func WaitForMLflowRunStatus(endpoint, runID, experimentID, expectedStatus string, timeout *time.Duration) error { | ||
| ginkgo.GinkgoHelper() | ||
| logger.Log("Waiting for MLflow run %s to reach status %s", runID, expectedStatus) | ||
| maxTimeToWait := time.Duration(300) |
Contributor
Author
There was a problem hiding this comment.
I will create follow PR to update the change the default from 300 to 120
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nsingla
reviewed
Jun 1, 2026
|
|
||
| // Verify the MLflow parent run reflects the retry | ||
| err = e2e_utils.VerifyMLflowRunStatus(mlflowEndpoint, rootRunID, mlflowExperimentID, "FAILED") | ||
| err = e2e_utils.WaitForMLflowRunStatus(mlflowEndpoint, rootRunID, mlflowExperimentID, "FAILED", &timeout) |
Contributor
There was a problem hiding this comment.
540sec is too long just to wait for mlflow run status to change
google-oss-prow
Bot
merged commit 763bfe9
into
kubeflow:mlflow-integration
161 of 165 checks passed
mprahl
pushed a commit
that referenced
this pull request
Jun 1, 2026
Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com>
google-oss-prow Bot
pushed a commit
that referenced
this pull request
Jun 1, 2026
* feat(backend): Add plugin input/output fields to RecurringRun and Run protobufs (#12919) Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com> * feat(backend): Add pipeline run lifecycle hooks Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> * feat(backend) integrate MLflow lifecycle hooks across the driver and launcher (#13052) Signed-off-by: Alyssa Goins <80764587+alyssacgoins@users.noreply.github.com> * chore(backend): Fix MLflow tags,nested run status update (#13307) Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> * test(backend): Add MLFlow Integrations tests with KFP (#13195) Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> * fix(backend): Address CI failures after rebase Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> * test(e2e): poll MLflow status after retry run failure (#13468) Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> --------- Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com> Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> Signed-off-by: Alyssa Goins <80764587+alyssacgoins@users.noreply.github.com> Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> Co-authored-by: Alyssa Goins <80764587+alyssacgoins@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This PR fixes the intermittent failures observed in MLflow retry run Integration test. Here is a recent test failure.
Fixes the race in the MLflow retry E2E test where the test asserted MLflow parent run status immediately after KFP reached a terminal state. This PR adds WaitForMLflowRunStatus, and uses it in the retry test instead of VerifyMLflowRunStatus.
Checklist: