Add queryParameters to Generic_list* api#293
Conversation
|
This looks good to me, but it is a breaking change, can we add this function as a new signature instead of breaking the existing signature? |
|
Yes sure, do you have a proposal for the naming? |
|
Oh, that's right, C doesn't allow the same fn name with different signatures :( In that case, I'm ok with this being a breaking change. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, hirishh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@brendandburns @ityuhui is it possible to release a new version? like v0.14.1? or v0.15.0 since it's not binary compatible... |
|
Hi @hirishh Typically, we release version v0.x, such as v0.15.0, in response to a new Kubernetes version release. Therefore, we plan to release a new version approximately every five to six months. Keeping pace with Kubernetes releases. Unless there's an urgent need, such as a security vulnerability, we don't plan to release a patch version like v0.14.1 due to limited development resources. So, can you use the mainline for now? Apologize for any inconvenience. |
Hello,
This PR allows the use of queryParameters in the
Generic_listandGeneric_listNamespacedapi.This is particularly useful for example to add "labelSelector" parameter.
I deal with a 5k nodes cluster, I need to save some bandwidth :)
Best,
hirishh