Skip to content

Add queryParameters to Generic_list* api#293

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
hirishh:feature-add-queryParameters-generic-list
Dec 2, 2025
Merged

Add queryParameters to Generic_list* api#293
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
hirishh:feature-add-queryParameters-generic-list

Conversation

@hirishh
Copy link
Copy Markdown
Contributor

@hirishh hirishh commented Nov 26, 2025

Hello,

This PR allows the use of queryParameters in the Generic_list and Generic_listNamespaced api.
This is particularly useful for example to add "labelSelector" parameter.

I deal with a 5k nodes cluster, I need to save some bandwidth :)

Best,

hirishh

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 26, 2025
@brendandburns
Copy link
Copy Markdown
Contributor

This looks good to me, but it is a breaking change, can we add this function as a new signature instead of breaking the existing signature?

@hirishh
Copy link
Copy Markdown
Contributor Author

hirishh commented Nov 26, 2025

Yes sure, do you have a proposal for the naming? Generic_list_qp and Generic_listNamespaced_qp?

@brendandburns
Copy link
Copy Markdown
Contributor

Oh, that's right, C doesn't allow the same fn name with different signatures :(

In that case, I'm ok with this being a breaking change.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, hirishh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5aaf0ac into kubernetes-client:master Dec 2, 2025
5 checks passed
@hirishh
Copy link
Copy Markdown
Contributor Author

hirishh commented Dec 2, 2025

@brendandburns @ityuhui is it possible to release a new version? like v0.14.1? or v0.15.0 since it's not binary compatible...

@ityuhui
Copy link
Copy Markdown
Member

ityuhui commented Dec 8, 2025

Hi @hirishh

Typically, we release version v0.x, such as v0.15.0, in response to a new Kubernetes version release. Therefore, we plan to release a new version approximately every five to six months. Keeping pace with Kubernetes releases.

Unless there's an urgent need, such as a security vulnerability, we don't plan to release a patch version like v0.14.1 due to limited development resources. So, can you use the mainline for now? Apologize for any inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants