test(e2e): Allow alternative helm charts in E2E test suite#2910
test(e2e): Allow alternative helm charts in E2E test suite#2910JoeNorth wants to merge 3 commits into
Conversation
The current E2E test suite is hardcoded to use the chart local to the repository. As part of testing an alternatively packaged, remote Helm chart the suite has been updated to allow specifying an arbitrary chart location and registry credentials. The default behavior remains unchanged.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @JoeNorth! |
|
Hi @JoeNorth. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When there are multiple args in HELM_EXTRA_FLAGS the current design introduces additonal spaces which causes to try to run it as a command. This change uses an array to handle it correctly.
|
This PR has multiple commits, and the default merge method is: merge. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@JoeNorth: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
The current E2E test suite is hardcoded to use the chart local to the repository. As part of testing an alternatively packaged, remote Helm chart the suite has been updated to allow specifying an arbitrary chart location and registry credentials. The default behavior remains unchanged.
How was this change tested?
The change was tested by running the E2E test suite on kops both with and without the new chart and registry credential variables.
Does this PR introduce a user-facing change?