Skip to content

test(e2e): Allow alternative helm charts in E2E test suite#2910

Open
JoeNorth wants to merge 3 commits into
kubernetes-sigs:masterfrom
JoeNorth:test/allow-alternate-charts
Open

test(e2e): Allow alternative helm charts in E2E test suite#2910
JoeNorth wants to merge 3 commits into
kubernetes-sigs:masterfrom
JoeNorth:test/allow-alternate-charts

Conversation

@JoeNorth

@JoeNorth JoeNorth commented Apr 1, 2026

Copy link
Copy Markdown

What type of PR is this?

/kind feature

What is this PR about? / Why do we need it?

The current E2E test suite is hardcoded to use the chart local to the repository. As part of testing an alternatively packaged, remote Helm chart the suite has been updated to allow specifying an arbitrary chart location and registry credentials. The default behavior remains unchanged.

How was this change tested?

The change was tested by running the E2E test suite on kops both with and without the new chart and registry credential variables.

Does this PR introduce a user-facing change?

NONE

The current E2E test suite is hardcoded to use the chart local to the
repository. As part of testing an alternatively packaged, remote Helm
chart the suite has been updated to allow specifying an arbitrary chart
location and registry credentials. The default behavior remains
unchanged.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 1, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andrewsirenko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @JoeNorth!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 1, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @JoeNorth. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 1, 2026
@JoeNorth JoeNorth changed the title test(e2e): Allow alternative helm charts test(e2e): Allow alternative helm charts in E2E test suite Apr 1, 2026
When there are multiple args in HELM_EXTRA_FLAGS the current design introduces additonal spaces which causes  to try to run it as a command. This change uses an array to handle it correctly.
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2026
@ConnorJC3

Copy link
Copy Markdown
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

@JoeNorth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-e2e-parameters 1e2f7a5 link true /test pull-aws-ebs-csi-driver-e2e-parameters

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants