🐛 fix: add missing RBAC delete permission for MachinePools in ROSA controller

[andclt]

What type of PR is this?

/kind bug

What this PR does / why we need it:

The ROSAControlPlane controller attempts to delete CAPI MachinePool resources during cluster deletion to work around ROSA-HCP's architectural constraint (clusters cannot exist without MachinePools). However, the RBAC ClusterRole is missing the delete verb for machinepools resources, causing deletion to fail with permission errors.

This PR adds delete verb to the cluster.x-k8s.io/machinepools RBAC marker in rosacontrolplane_controller.go

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://redhat.atlassian.net/browse/ROSAENG-59186

Special notes for your reviewer:

AI Usage:

None

Checklist:

• squashed commits
• includes documentation
• includes AI generated content
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

fix(rosa): cluster deletion getting stuck due to missing RBAC permission for deleting MachinePools

[kubernetes-prow]

Hi @andclt. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[damdo]

/ok-to-test

[damdo]

/approve

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damdo]

/assign @serngawy @nrb

[serngawy]

We should also consider deleting the cluster CR to cascade delete the ROSACluster CR, otherwise both CRs will be left over. Lets do it in another PR, this PR looks good to me.

[damdo]

/lgtm

[kubernetes-prow]

LGTM label has been added.

Details

Git tree hash: ecdfec320e262a7fbfc8b9f559a89f8d0bf71511