KAL: Enable statusoptional and fix

Ensure all status fields have only optional first children.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>

Author: lentzi90

.golangci-kal.yml

@@ -33,7 +33,7 @@ linters:
             # - "optionalorrequired" # Every field should be marked as optional or required.
             # - "requiredfields" # Required fields should not be pointers, and should not have omitempty.
             # - "ssatags" # Ensure array fields have the appropriate listType markers.
-            # - "statusoptional" # Ensure all first children within status should be optional.
+            - "statusoptional" # Ensure all first children within status should be optional.
             - "statussubresource" # All root objects that have a status field should have a status subresource.
             - "uniquemarkers" # Ensure that types and fields do not contain more than a single definition of a marker that should only be present once.
             - "nophase" # Phase fields are discouraged by the Kube API conventions, use conditions instead.

api/v1beta2/openstackcluster_types.go

@@ -229,6 +229,7 @@ type OpenStackClusterStatus struct {
 	APIServerLoadBalancer *LoadBalancer `json:"apiServerLoadBalancer,omitempty"`
 
 	// failureDomains represent OpenStack availability zones
+	// +optional
 	FailureDomains []clusterv1.FailureDomain `json:"failureDomains,omitempty"`
 
 	// controlPlaneSecurityGroup contains the information about the

api/v1beta2/openstackmachine_types.go

@@ -204,6 +204,7 @@ type OpenStackMachineStatus struct {
 	InstanceID optional.String `json:"instanceID,omitempty"`
 
 	// addresses contains the OpenStack instance associated addresses.
+	// +optional
 	Addresses []corev1.NodeAddress `json:"addresses,omitempty"`
 
 	// instanceState is the state of the OpenStack instance for this machine.