-
Notifications
You must be signed in to change notification settings - Fork 298
Fix duplicate linter config and comments for dot imports #2995
Copy link
Copy link
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Type
Projects
Status
Done
We currently add
//nolintcomments for dot imports. See for example:cluster-api-provider-openstack/controllers/openstackcluster_controller_test.go
Lines 30 to 31 in 31797cd
At the same time we configure the linter to ignore these in .golangci.yml:
cluster-api-provider-openstack/.golangci.yml
Lines 163 to 166 in 31797cd
There must be something wrong with this config or the
//nolintcomments would not be needed.Figure out what the config should look like and remove the
//nolintcomments from all places where we use dot imports for ginkgo and gomega./help
/good-first-issue