Skip to content

🌱 E2E: Add quick-start test using ClusterClass#2793

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
Nordix:lentzi90/topology-e2e
Oct 24, 2025
Merged

🌱 E2E: Add quick-start test using ClusterClass#2793
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
Nordix:lentzi90/topology-e2e

Conversation

@lentzi90
Copy link
Copy Markdown
Contributor

@lentzi90 lentzi90 commented Oct 21, 2025

What this PR does / why we need it:

Add a test using our ClusterClass.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2105

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 21, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit deaa56e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68fb247d9c752200087e53b5
😎 Deploy Preview https://deploy-preview-2793--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 21, 2025
@lentzi90 lentzi90 changed the title E2E: Add quick-start test using ClusterClass 🌱 E2E: Add quick-start test using ClusterClass Oct 21, 2025
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Oct 21, 2025

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2025
@lentzi90 lentzi90 force-pushed the lentzi90/topology-e2e branch 2 times, most recently from 6bacc28 to da1f4dc Compare October 22, 2025 06:14
@lentzi90 lentzi90 changed the title 🌱 E2E: Add quick-start test using ClusterClass 🌱 E2E: Add quick-start test using ClusterClass Oct 22, 2025
bnallapeta
bnallapeta reviewed Oct 22, 2025
View reviewed changes
Comment thread templates/cluster-template-topology.yaml Outdated
cloudName: ${OPENSTACK_CLOUD:=capo-e2e}
name: ${CLOUD_CONFIG_SECRET:=dev-test-cloud-config}
- name: imageName
value: ${IMAGE_NAME:=flatcar_production}
Copy link
Copy Markdown
Contributor

@bnallapeta bnallapeta Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default to ubuntu like most tests?

Copy link
Copy Markdown
Contributor Author

@lentzi90 lentzi90 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I could do that. I noticed a few issues with the ClusterClass that I need to fix to get the tests passing also. Will add ORC image references at least

Copy link
Copy Markdown
Contributor Author

@lentzi90 lentzi90 Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to go with the flatcar image for now since that is one that users can also use. We cannot encourage them to use the ubuntu images we have in CI since that would add cost to the project.

@lentzi90 lentzi90 force-pushed the lentzi90/topology-e2e branch 3 times, most recently from c70f787 to ce60a04 Compare October 24, 2025 05:10
@lentzi90
E2E: Add quick-start test using ClusterClass
deaa56e 
This commit also fixes a few remaining v1beta1 references
in the ClusterClass and adds support for setting images
through imageRef.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@lentzi90 lentzi90 force-pushed the lentzi90/topology-e2e branch from ce60a04 to deaa56e Compare October 24, 2025 07:02
@lentzi90
Copy link
Copy Markdown
Contributor Author

lentzi90 commented Oct 24, 2025

/approve
This is ready to take in

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2025
smoshiur1237
smoshiur1237 reviewed Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2025
@lentzi90
Copy link
Copy Markdown
Contributor Author

lentzi90 commented Oct 24, 2025

/test pull-cluster-api-provider-openstack-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit afbe65a into kubernetes-sigs:main Oct 24, 2025
11 of 12 checks passed
@github-project-automation github-project-automation Bot moved this from Inbox to Done in CAPO Roadmap Oct 24, 2025
@lentzi90 lentzi90 deleted the lentzi90/topology-e2e branch October 24, 2025 09:43
@lentzi90 lentzi90 mentioned this pull request Oct 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

2 more reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@bnallapeta bnallapeta bnallapeta left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@smoshiur1237 smoshiur1237

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

CAPO Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: e2e test that makes use of the clusterclass-dev template

5 participants

@lentzi90 @k8s-triage-robot @k8s-ci-robot @smoshiur1237 @bnallapeta