⚠️ Rename managedSecurityGroups.allNodesSecurityGroupRules#3155
Open
nikParasyr wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
⚠️ Rename managedSecurityGroups.allNodesSecurityGroupRules#3155nikParasyr wants to merge 1 commit intokubernetes-sigs:mainfrom
nikParasyr wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
size/L
Rename `spec.managedSecurityGroups.allNodesSecurityGroupRules` to `spec.managedSecurityGroups.clusterNodesSecurityGroupRules` to clarify that these rules apply only to cluster nodes (control plane and workers), and not to other managed resources such as the bastion host.
Contributor
Author
|
/retest |
Contributor
Author
|
/cc @lentzi90 @bnallapeta |
bnallapeta
suggested changes
May 7, 2026
Contributor
bnallapeta
left a comment
bnallapeta
left a comment
There was a problem hiding this comment.
allNodesSecurityGroupRules
- the same rename change has to occur in e2e and docs too.
| allErrs = append(allErrs, validateSecurityGroupRulesRemoteMutualExclusion( | ||
| msg.AllNodesSecurityGroupRules, | ||
| msg.ClusterNodesSecurityGroupRules, | ||
| field.NewPath("spec", "managedSecurityGroups", "allNodesSecurityGroupRules"), |
Contributor
There was a problem hiding this comment.
we need to replace ClusterNodesSecurityGroupRules here too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Rename
spec.managedSecurityGroups.allNodesSecurityGroupRulestospec.managedSecurityGroups.clusterNodesSecurityGroupRulesto clarify that these rules apply only to cluster nodes (control plane and workers), and not to other managed resources such as the bastion host.Which issue(s) this PR fixes:
Fixes #3055
TODOs:
/hold