-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add machineNaming support to MachineDeploymentClass and MachineDeploymentTopology #13540
Copy link
Copy link
Open
Labels
area/apiIssues or PRs related to the APIsIssues or PRs related to the APIsarea/clusterclassIssues or PRs related to clusterclassIssues or PRs related to clusterclassarea/machinedeploymentIssues or PRs related to machinedeploymentsIssues or PRs related to machinedeploymentshelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.priority/backlogHigher priority than priority/awaiting-more-evidence.Higher priority than priority/awaiting-more-evidence.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Metadata
Metadata
Assignees
Labels
area/apiIssues or PRs related to the APIsIssues or PRs related to the APIsarea/clusterclassIssues or PRs related to clusterclassIssues or PRs related to clusterclassarea/machinedeploymentIssues or PRs related to machinedeploymentsIssues or PRs related to machinedeploymentshelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.priority/backlogHigher priority than priority/awaiting-more-evidence.Higher priority than priority/awaiting-more-evidence.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Type
Fields
Give feedbackNo fields configured for issues without a type.
What would you like to be added (User Story)?
machineNamingfield fromMachineDeploymentSpecshould be exposed inMachineDeploymentClassandMachineDeploymentTopologyso topology-managed clusters can customize Machine names within MachineDeployments.Detailed Description
machineNamingonMachineDeploymentSpecallows customizing Machine names, but the topology controller doesn't propagate it. There's no way to set it through ClusterClass or Cluster topology.This means topology-managed MachineDeployments always produce Machine names like
cluster-worker-8fh2k-xn4wp(MachineSet name + random suffix). There's no way to simplify this to e.g.cluster-worker-xn4wp.Proposal: add
machineNamingtoMachineDeploymentClasswith optional override inMachineDeploymentTopology, same as how naming already works for the MachineDeployment object name.References:
Anything else you would like to add?
Same gap applies to
MachinePoolClass/MachinePoolTopology.Label(s) to be applied
/kind feature
/area clusterclass
/area machinedeployment
/area api