✨ Disable the webhook server by setting the port to -1#3481
Open
troy0820 wants to merge 2 commits intokubernetes-sigs:mainfrom
Open
✨ Disable the webhook server by setting the port to -1#3481troy0820 wants to merge 2 commits intokubernetes-sigs:mainfrom
troy0820 wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
k8s-ci-robot
added
cncf-cla: yes
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: troy0820 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3456
Currently there is no way to disable the webhook server. If we don't set the option, we get one automatically. If we set the port to -1 it would set it to the default port.
This change adds a DisabledServer that Satisfies the webhook.Server interface and allows the port to be set to -1 to signal the disabling of the webhook server. The controller manager will now allow the server to be nil and not panic in order to allow the change to work.
/assign @sbueringer