Skip to content

⚠️ Bump to k8s.io/* v0.36.0-beta.0#3486

Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
kunalmemane:bump-v0.36-beta.0
Mar 31, 2026
Merged

⚠️ Bump to k8s.io/* v0.36.0-beta.0#3486
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
kunalmemane:bump-v0.36-beta.0

Conversation

@kunalmemane
Copy link
Copy Markdown
Contributor

@kunalmemane kunalmemane commented Mar 27, 2026 •
edited
Loading

Bump to k8s.io/* v0.36.0-beta.0

Follow-up: #3488

Signed-off-by: Kunal Memane kmemane@redhat.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2026
@k8s-ci-robot k8s-ci-robot requested a review from joelanford March 27, 2026 13:22
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 27, 2026

Welcome @kunalmemane!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from vincepri March 27, 2026 13:22
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 27, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 27, 2026

Hi @kunalmemane. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2026
@kunalmemane
Copy link
Copy Markdown
Contributor Author

kunalmemane commented Mar 27, 2026 •
edited
Loading

Hi @sbueringer, Could you please help with a review on this PR? Thanks!

@alvaroaleman
Copy link
Copy Markdown
Member

alvaroaleman commented Mar 29, 2026

There is no grpc server in controller runtime so the cve doesn't apply.

@sbueringer
Copy link
Copy Markdown
Member

sbueringer commented Mar 30, 2026

@alvaroaleman But independent of the PR title we would want to bump to beta.0, right?

@alvaroaleman
Copy link
Copy Markdown
Member

alvaroaleman commented Mar 30, 2026

@alvaroaleman But independent of the PR title we would want to bump to beta.0, right?

Yeah, true

@alvaroaleman alvaroaleman reopened this Mar 30, 2026
@alvaroaleman alvaroaleman changed the title ⚠️ Bump to k8s.io/* v0.36.0-beta.0 to fix CVE-2026-33186 ⚠️ Bump to k8s.io/* v0.36.0-beta.0 Mar 30, 2026
@alvaroaleman
Copy link
Copy Markdown
Member

alvaroaleman commented Mar 30, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2026
@kunalmemane
Copy link
Copy Markdown
Contributor Author

kunalmemane commented Mar 30, 2026

/test pull-controller-runtime-test

@kunalmemane kunalmemane force-pushed the bump-v0.36-beta.0 branch 4 times, most recently from f18b8e9 to be64ad4 Compare March 30, 2026 17:01
@kunalmemane
Copy link
Copy Markdown
Contributor Author

kunalmemane commented Mar 30, 2026

Hi @alvaroaleman Can you help with a review on this PR.

@alvaroaleman alvaroaleman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 31, 2026
@kunalmemane
Copy link
Copy Markdown
Contributor Author

kunalmemane commented Mar 31, 2026

Hi @sbueringer, Kindly request a review on this PR. TIA.

sbueringer
sbueringer reviewed Mar 31, 2026
View reviewed changes
Comment thread examples/scratch-env/go.mod
Comment thread .golangci.yml
Comment thread pkg/metrics/filters/filter_suite_test.go Outdated
@kunalmemane
Bump to k8s.io/* v0.36.0-beta.0
ac40242 
Signed-off-by: Kunal Memane <kmemane@redhat.com>
@kunalmemane
Update golangci-lint config for Go 1.26
159cd9c 
Bump the go version from 1.25 to 1.26 and disable the modernize/newexpr
lint check which flags all ptr.To(x) calls as replaceable with new(x).

Signed-off-by: Kunal Memane <kmemane@redhat.com>
@kunalmemane
Fix test panics from *http.Transport type assertion with client-go v0…
d4babe3 
….36.0-beta.0

Signed-off-by: Kunal Memane <kmemane@redhat.com>
@sbueringer
Copy link
Copy Markdown
Member

sbueringer commented Mar 31, 2026

Thx!

/lgtm
/assign @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 31, 2026

LGTM label has been added.

DetailsGit tree hash: 1c7f4ed32806fb8585521df152030548be94cb3d

alvaroaleman
alvaroaleman approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, kunalmemane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026
@k8s-ci-robot k8s-ci-robot merged commit 598e330 into kubernetes-sigs:main Mar 31, 2026
14 checks passed
@kunalmemane
Copy link
Copy Markdown
Contributor Author

kunalmemane commented Mar 31, 2026

Created a followup PR for issue - #3488

Need /ok-to-test on PR - #3489

@gokken-roko gokken-roko mentioned this pull request Apr 1, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

@alvaroaleman alvaroaleman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kunalmemane @k8s-ci-robot @alvaroaleman @sbueringer