Skip to content

🐛 Add missing space in zap-log-level flag description#3492

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
erikgb:fix-flag-missing-space
Apr 4, 2026
Merged

🐛 Add missing space in zap-log-level flag description#3492
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
erikgb:fix-flag-missing-space

Conversation

@erikgb
Copy link
Copy Markdown
Member

@erikgb erikgb commented Apr 3, 2026

This adds a missing space to the zap-log-level flag description to avoid bad wording in operators inheriting the controller-runtime flags. This is how this flag output prints now:

-zap-log-level level                Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', 'panic'or any integer value > 0 which corresponds to custom debug levels of increasing verbosity

@k8s-ci-robot k8s-ci-robot requested review from inteon and vincepri April 3, 2026 16:10
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 3, 2026
@erikgb erikgb changed the title 🐛 Add missing space in zap-log-level flag docs 🐛 Add missing space in zap-log-level flag description Apr 3, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: acc81aac490012a1e6ba53ab270f5326284c061e

@inteon
Copy link
Copy Markdown
Member

inteon commented Apr 4, 2026

/lgtm

Copy link
Copy Markdown
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2026
@k8s-ci-robot k8s-ci-robot merged commit a387321 into kubernetes-sigs:main Apr 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants