✨ Improve logging for dynamic type kind source#3494
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Apr 5, 2026
Merged
✨ Improve logging for dynamic type kind source#3494k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
alvaroaleman
reviewed
Apr 5, 2026
| switch v := any(ks.Type).(type) { | ||
| case *unstructured.Unstructured, *metav1.PartialObjectMetadata: | ||
| gvk := v.(client.Object).GetObjectKind().GroupVersionKind() | ||
| return fmt.Sprintf("kind source: %T[%s]", v, gvk.Kind) |
Member
There was a problem hiding this comment.
I don't know if just the kind is always enough, could we also add the GV?
Member
Author
There was a problem hiding this comment.
Sure! Which string format do you prefer? I have just committed my suggestion. 😸
erikgb
force-pushed
the
improve-kind-source-logging
branch
from
3b4164b to
6f89e1d
Compare
alvaroaleman
approved these changes
Apr 5, 2026
Member
alvaroaleman
left a comment
alvaroaleman
left a comment
There was a problem hiding this comment.
That looks good, thanks!
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 74555158d0867e84ca634b2b692f750ea97a8a2e |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the logging when using a dynamic type (Unstructured and PartialObjectMetadata) with a kind source. Including information about the underlying type (kind) should make it easier to reason about what's going on. Implementation as suggested in #3493 (comment).
Was a bit in doubt about only logging the kind or the full GVK. I landed on the just the kind, but please let me know if you want me to change this.
Fixes #3493