address review: fix args

Signed-off-by: Swati Gupta <swatig@nvidia.com>

Author: guptaNswati

cmd/gpu-kubelet-plugin/allocatable.go

@@ -326,31 +326,23 @@ func (d *AllocatableDevice) Taints() []resourceapi.DeviceTaint {
 // (e.g., XID 48 followed by XID 63), the value is overwritten and only the most recent event data is retained.
 // Returns true if the taint set was modified.
 func (d *AllocatableDevice) AddOrUpdateTaint(taint *resourceapi.DeviceTaint) bool {
-	t := *taint
 	for i, existing := range d.taints {
-		if existing.Key == t.Key {
-			changed := false
+		if existing.Key == taint.Key {
 
-			// Overwrite Value if it changed
-			if existing.Value != t.Value {
-				d.taints[i].Value = t.Value
-				changed = true
+			// 1. If nothing actually changed, exit early to avoid API calls
+			if existing.Value == taint.Value && existing.Effect == taint.Effect {
+				return false
 			}
 
-			if existing.Effect != t.Effect {
-				d.taints[i].Effect = t.Effect
-				changed = true
-			}
-
-			if changed {
-				d.taints[i].TimeAdded = nil // reset timestamp for the API server
-			}
-
-			return changed
+			// 2. Otherwise, update the fields and the timestamp
+			d.taints[i].Value = taint.Value
+			d.taints[i].Effect = taint.Effect
+			d.taints[i].TimeAdded = nil // reset timestamp for the API server
+			return true
 		}
 	}
 
-	// Key doesn't exist yet, append the new taint
-	d.taints = append(d.taints, t)
+	// 3. Key doesn't exist yet, append the dereferenced struct
+	d.taints = append(d.taints, *taint)
 	return true
 }

cmd/gpu-kubelet-plugin/device_health.go

@@ -72,7 +72,7 @@ type DeviceHealthEvent struct {
 // healthEventToTaint maps a DeviceHealthEvent to the corresponding DRA
 // DeviceTaint using the Option A taint key schema: one key per health
 // dimension under the gpu.nvidia.com domain.
-func healthEventToTaint(event *DeviceHealthEvent, monitor deviceHealthMonitor) *resourceapi.DeviceTaint {
+func healthEventToTaint(monitor deviceHealthMonitor, event *DeviceHealthEvent) *resourceapi.DeviceTaint {
 	switch event.EventType {
 	case HealthEventXID:
 		effect := resourceapi.DeviceTaintEffectNoSchedule

cmd/gpu-kubelet-plugin/device_health_test.go

@@ -224,7 +224,7 @@ func TestHealthEventToTaint(t *testing.T) {
 
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {
-			taint := healthEventToTaint(tc.event, tc.monitor)
+			taint := healthEventToTaint(tc.monitor, tc.event)
 			assert.Equal(t, tc.expectedKey, taint.Key)
 			assert.Equal(t, tc.expectedValue, taint.Value)
 			assert.Equal(t, tc.expectedEffect, taint.Effect)

cmd/gpu-kubelet-plugin/driver.go

@@ -471,7 +471,7 @@ func (d *driver) deviceHealthEvents(ctx context.Context, nodeName string) {
 				return
 			}
 
-			taint := healthEventToTaint(event, d.deviceHealthMonitor)
+			taint := healthEventToTaint(d.deviceHealthMonitor, event)
 			modified := false
 			for _, dev := range event.Devices {
 				klog.Warningf("Received %s health event for device %s", event.EventType, dev.UUID())