Skip to content

Commit aa5a432

Browse files
committed
Remove helm value for gpuResourcesEnabledOverride
With this removed, the GPU side of the driver will be enabled by default with no safeguards to ensure that someone explicity sets it to false if that is their actual intention. Signed-off-by: Kevin Klues <kklues@nvidia.com>
1 parent 37d9a5c commit aa5a432

3 files changed

Lines changed: 0 additions & 11 deletions

File tree

demo/clusters/kind/install-dra-driver-gpu.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ kubectl label node -l node-role.x-k8s.io/worker --overwrite nvidia.com/gpu.prese
2727
helm upgrade -i --create-namespace --namespace nvidia-dra-driver-gpu nvidia-dra-driver-gpu ${PROJECT_DIR}/deployments/helm/nvidia-dra-driver-gpu \
2828
${NVIDIA_DRIVER_ROOT:+--set nvidiaDriverRoot=${NVIDIA_DRIVER_ROOT}} \
2929
${MASK_NVIDIA_DRIVER_PARAMS:+--set maskNvidiaDriverParams=${MASK_NVIDIA_DRIVER_PARAMS}} \
30-
--set gpuResourcesEnabledOverride=true \
3130
--wait
3231

3332
set +x

deployments/helm/nvidia-dra-driver-gpu/templates/validation.yaml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,6 @@
3030
{{- fail $error }}
3131
{{- end }}
3232

33-
{{- if and .Values.resources.gpus.enabled (not .Values.gpuResourcesEnabledOverride) }}
34-
{{- $error := "" }}
35-
{{- $error = printf "%s\nThe default value of 'resources.gpus.enabled=true' is not yet supported." $error }}
36-
{{- $error = printf "%s\nIt is set to true by default to future proof it as the default once support for it becomes available." $error }}
37-
{{- $error = printf "%s\nUntil then, please explicitly set 'resources.gpus.enabled=false' when installing this chart." $error }}
38-
{{- $error = printf "%s\nIf you truly want to force 'resources.gpus.enabled=true' to apply, you must also set 'gpuResourcesEnabledOverride=true'." $error }}
39-
{{- fail $error }}
40-
{{- end }}
41-
4233
{{- if .Values.nvidiaCtkPath }}
4334
{{- $error := "" }}
4435
{{- $error = printf "%s\nSetting a user-defined nvidiaCtkPath is no longer supported. It can simply be removed without consequence." $error }}

deployments/helm/nvidia-dra-driver-gpu/values.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ nameOverride: ""
3030
fullnameOverride: ""
3131
namespaceOverride: ""
3232
selectorLabelsOverride: {}
33-
gpuResourcesEnabledOverride: false
3433

3534
allowDefaultNamespace: false
3635

0 commit comments

Comments
 (0)