address review: return a copy of taints to avoid race conditions

guptaNswati · guptaNswati · commit e99bfb8ed50b · 2026-04-09T18:32:13.000Z
Signed-off-by: Swati Gupta &lt;swatig@nvidia.com&gt;
diff --git a/cmd/gpu-kubelet-plugin/allocatable.go b/cmd/gpu-kubelet-plugin/allocatable.go
@@ -277,8 +277,10 @@ func (d AllocatableDevices) RemoveSiblingDevices(device *AllocatableDevice) {
 	}
 }
 
+// Taints returns a copy of the device's taints to prevent data races
+// when being read concurrently by the ResourceSlice builder.
 func (d *AllocatableDevice) Taints() []resourceapi.DeviceTaint {
-	return d.taints
+	return slices.Clone(d.taints)
 }
 
 // AddOrUpdateTaint adds a new taint or updates an existing one with the same

Original file line number	Diff line number	Diff line change
`@@ -277,8 +277,10 @@ func (d AllocatableDevices) RemoveSiblingDevices(device *AllocatableDevice) {`
`277`	`277`	`}`
`278`	`278`	`}`
`279`	`279`
	`280`	`+// Taints returns a copy of the device's taints to prevent data races`
	`281`	`+// when being read concurrently by the ResourceSlice builder.`
`280`	`282`	`func (d *AllocatableDevice) Taints() []resourceapi.DeviceTaint {`
`281`		`- return d.taints`
	`283`	`+ return slices.Clone(d.taints)`
`282`	`284`	`}`
`283`	`285`
`284`	`286`	`// AddOrUpdateTaint adds a new taint or updates an existing one with the same`