Skip to content

Update kubelet/pkg/apis/dra to v1#138

Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes-sigs:mainfrom
sunya-ch:update-deviceapi
Jun 25, 2026
Merged

Update kubelet/pkg/apis/dra to v1#138
kubernetes-prow[bot] merged 2 commits into
kubernetes-sigs:mainfrom
sunya-ch:update-deviceapi

Conversation

@sunya-ch

@sunya-ch sunya-ch commented Jan 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Update k8s.io/kubelet/pkg/apis/dra from v1beta1 to v1 and support ShareId field.

Related to

@k8s-ci-robot

k8s-ci-robot commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunya-ch
Once this PR has been reviewed and has the lgtm label, please assign byako for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from elezar and pohly January 19, 2026 04:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2026
@pohly pohly moved this from 🆕 New to 👀 In review in Dynamic Resource Allocation Jan 19, 2026
@sunya-ch sunya-ch mentioned this pull request Jan 19, 2026
Open
pohly
pohly reviewed Jan 22, 2026
View reviewed changes

@pohly pohly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @nojnhuh

Looks okay to me, but I'll defer to @nojnhuh for details.

nojnhuh
nojnhuh reviewed Feb 3, 2026
View reviewed changes
Comment thread cmd/dra-example-kubeletplugin/state.go
"k8s.io/apimachinery/pkg/runtime/serializer/json"
"k8s.io/dynamic-resource-allocation/resourceslice"
drapbv1 "k8s.io/kubelet/pkg/apis/dra/v1beta1"
drapbv1 "k8s.io/kubelet/pkg/apis/dra/v1"

@nojnhuh nojnhuh Feb 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember choosing not to do this sooner since it changes the format of checkpoints on disk: #123 (comment). I'm not really sure what the implications of that are, especially w.r.t. driver upgrades.

@bart0sh @klueska @pohly How should drivers generally be utilizing checkpoints? Is this the right way to integrate the share_id of a device into the checkpoint?

@pohly pohly Feb 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should use a format that is entirely under their own control, ideally using versioning to enable conversion if the driver needs to change the format.

The kubelet checkpointing code is seriously flawed because it checksums the in-memory representation. See discussion in #90 (comment).

@k8s-triage-robot

k8s-triage-robot commented May 5, 2026

Copy link
Copy Markdown

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2026
@nojnhuh

nojnhuh commented May 5, 2026

Copy link
Copy Markdown
Contributor

I'd still like to get #148 first. Then this won't affect anything that the driver writes to disk.

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2026
@nojnhuh nojnhuh mentioned this pull request May 6, 2026
Open
@nojnhuh

nojnhuh commented May 12, 2026

Copy link
Copy Markdown
Contributor

@sunya-ch This should be unblocked now that #148 merged. Could you please rebase?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2026
@k8s-ci-robot

k8s-ci-robot commented May 12, 2026

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sunya-ch added 2 commits June 25, 2026 10:27
@sunya-ch
Update kubelet/pkg/apis/dra to v1
a37a42b 
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
@sunya-ch
Convert Errorf to contextual logging
253d287 
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
@kubernetes-prow kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2026
@sunya-ch

sunya-ch commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@nojnhuh I'm sorry that I just noticed this. I have rebased the PR and as I was prevented from running the test with contextual logging check so I add a second comment to fix that.

nojnhuh
nojnhuh approved these changes Jun 25, 2026
View reviewed changes

@nojnhuh nojnhuh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: fe762b4b556966e0844fa5fa6c091b49d3b79440

@kubernetes-prow

kubernetes-prow Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh, sunya-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2026
@kubernetes-prow kubernetes-prow Bot merged commit ab415b1 into kubernetes-sigs:main Jun 25, 2026
6 checks passed
@sunya-ch sunya-ch deleted the update-deviceapi branch June 25, 2026 06:34
@pohly pohly moved this from 👀 In review to ✅ Done in Dynamic Resource Allocation Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pohly pohly pohly left review comments
@nojnhuh nojnhuh nojnhuh approved these changes
@elezar elezar Awaiting requested review from elezar

Assignees

@nojnhuh nojnhuh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sunya-ch @k8s-ci-robot @k8s-triage-robot @nojnhuh @pohly @mbrow137