Update kubelet/pkg/apis/dra to v1#138
Conversation
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sunya-ch The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| "k8s.io/apimachinery/pkg/runtime/serializer/json" | ||
| "k8s.io/dynamic-resource-allocation/resourceslice" | ||
| drapbv1 "k8s.io/kubelet/pkg/apis/dra/v1beta1" | ||
| drapbv1 "k8s.io/kubelet/pkg/apis/dra/v1" |
There was a problem hiding this comment.
I remember choosing not to do this sooner since it changes the format of checkpoints on disk: #123 (comment). I'm not really sure what the implications of that are, especially w.r.t. driver upgrades.
@bart0sh @klueska @pohly How should drivers generally be utilizing checkpoints? Is this the right way to integrate the share_id of a device into the checkpoint?
There was a problem hiding this comment.
They should use a format that is entirely under their own control, ideally using versioning to enable conversion if the driver needs to change the format.
The kubelet checkpointing code is seriously flawed because it checksums the in-memory representation. See discussion in #90 (comment).
Update
k8s.io/kubelet/pkg/apis/drafromv1beta1tov1and supportShareIdfield.Related to