Skip to content

Refactor e2e tests to ginkgo framework#153

Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
Shilpa-Gokul:e2e-test
Apr 21, 2026
Merged

Refactor e2e tests to ginkgo framework#153
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
Shilpa-Gokul:e2e-test

Conversation

@Shilpa-Gokul
Copy link
Copy Markdown
Contributor

@Shilpa-Gokul Shilpa-Gokul commented Feb 16, 2026 •
edited
Loading

Partially fixes #145

This PR focuses on converting the bash based code in test/e2e/e2e.sh to ginkgo tests. make test-e2e command will now invoke the tests using ginkgo command.

Since this PR has already reached size XL, I’ve decided to move the pending items listed below to a follow-up PR to keep the review process manageable. Hope that's fine!

  • Change all the code in test/e2e/setup-e2e.sh and test/e2e/teardown-e2e.sh to ginkgo tests
  • Cleanup the existing bash based test scripts (e2e.sh, setup-e2e.sh, teardown-e2e.sh)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2026
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 16, 2026

Welcome @Shilpa-Gokul!

It looks like this is your first PR to kubernetes-sigs/dra-example-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/dra-example-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 16, 2026
@Shilpa-Gokul Shilpa-Gokul force-pushed the e2e-test branch 2 times, most recently from c3fd93b to c585ef9 Compare February 16, 2026 13:20
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 16, 2026
@mortent mortent moved this from 🆕 New to 🏗 In progress in Dynamic Resource Allocation Feb 17, 2026
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 18, 2026
@Shilpa-Gokul Shilpa-Gokul force-pushed the e2e-test branch 5 times, most recently from 88c047e to 47c1d38 Compare February 19, 2026 06:40
@Shilpa-Gokul Shilpa-Gokul marked this pull request as ready for review February 19, 2026 07:10
@k8s-ci-robot k8s-ci-robot requested a review from pohly February 19, 2026 07:10
@Shilpa-Gokul
Copy link
Copy Markdown
Contributor Author

Shilpa-Gokul commented Feb 19, 2026

Looking forward to any feedback or comments on the implementation.

cc @nojnhuh

@Shilpa-Gokul Shilpa-Gokul force-pushed the e2e-test branch 6 times, most recently from 1479579 to 9f4c425 Compare February 20, 2026 10:50
@Shilpa-Gokul Shilpa-Gokul changed the title [WIP] Refactor e2e tests to ginkgo framework Refactor e2e tests to ginkgo framework Feb 20, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2026
@Shilpa-Gokul Shilpa-Gokul force-pushed the e2e-test branch 2 times, most recently from 41419b2 to 65e092f Compare April 3, 2026 10:29
@Shilpa-Gokul
Copy link
Copy Markdown
Contributor Author

Shilpa-Gokul commented Apr 3, 2026

@nojnhuh Thank you so much for taking time to review this PR. I have addressed all the review comments and have tested the changes too. Could you please take a look when time permits??

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2026
nojnhuh
nojnhuh requested changes Apr 13, 2026
View reviewed changes
Comment thread test/e2e/e2e_setup_test.go
Comment thread test/e2e/e2e_setup_test.go Outdated
Comment thread test/e2e/e2e_setup_test.go Outdated
Comment thread test/e2e/e2e_setup_test.go Outdated
Comment thread test/e2e/e2e_setup_test.go Outdated
Comment thread test/e2e/e2e_test.go Outdated
Comment thread test/e2e/e2e_test.go
Comment thread test/e2e/e2e_setup_test.go Outdated
Comment thread test/e2e/e2e_test.go Outdated
Comment thread test/e2e/e2e_test.go Outdated
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 20, 2026
@Shilpa-Gokul
Convert bash based e2e tests to ginkgo tests
7b20d7b 
Signed-off-by: Shilpa-Gokul <shilpagokul95@gmail.com>
@Shilpa-Gokul
Addressed review comments
7c9b507
@Shilpa-Gokul
Copy link
Copy Markdown
Contributor Author

Shilpa-Gokul commented Apr 20, 2026

@nojnhuh I have addressed all the comments. Could you please take a look when time permits. Thanks in advance

nojnhuh
nojnhuh reviewed Apr 20, 2026
View reviewed changes
Comment thread test/e2e/e2e_setup_test.go Outdated
Comment thread test/e2e/e2e_setup_test.go Outdated
nojnhuh
nojnhuh reviewed Apr 20, 2026
View reviewed changes
Comment thread test/e2e/e2e_setup_test.go Outdated
@nojnhuh nojnhuh mentioned this pull request Apr 20, 2026
Draft
@Shilpa-Gokul
Copy link
Copy Markdown
Contributor Author

Shilpa-Gokul commented Apr 21, 2026

@nojnhuh Addressed all the comments. Could you please review when you get some time. Thanks in advance.

nojnhuh
nojnhuh approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This sets us up well to continue to iterate.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 21, 2026

LGTM label has been added.

DetailsGit tree hash: 2c4eac4aa476cad1d2893b6933f89548c9aed3f3

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh, Shilpa-Gokul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2026
@k8s-ci-robot k8s-ci-robot merged commit f9f4ccb into kubernetes-sigs:main Apr 21, 2026
6 checks passed
@pohly pohly moved this from 👀 In review to ✅ Done in Dynamic Resource Allocation Apr 22, 2026
@nojnhuh nojnhuh mentioned this pull request Apr 24, 2026
Merged
@Shilpa-Gokul Shilpa-Gokul mentioned this pull request Apr 29, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nojnhuh nojnhuh nojnhuh approved these changes

@byako byako Awaiting requested review from byako

@klueska klueska Awaiting requested review from klueska

@pohly pohly Awaiting requested review from pohly

Assignees

@nojnhuh nojnhuh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor e2e tests into a real framework

6 participants

@Shilpa-Gokul @k8s-ci-robot @nojnhuh @pohly @mortent @mbrow137