Enable DRA device metadata (KEP-5304)#164
Enable DRA device metadata (KEP-5304)#164carlory wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: carlory The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3e77fa1 to
c424108
Compare
81c79eb to
7d6235f
Compare
7d6235f to
77ab291
Compare
| k8s.io/client-go v0.35.4 | ||
| k8s.io/component-base v0.35.4 | ||
| k8s.io/dynamic-resource-allocation v0.35.4 | ||
| k8s.io/api v0.36.0-rc.1 |
There was a problem hiding this comment.
I have a draft of the changes to bump to 1.36 here but haven't opened a PR yet: main...nojnhuh:dra-example-driver:k8s-1.36
I'm ok if we want to do that in this PR, but can we at least make those changes a separate commit here? There are also some other places that need to be updated here that you can check against my branch.
There was a problem hiding this comment.
v1.36 will be released in two days, once it is released, I will update this PR.
| affinity: {} | ||
| kubeletRegistrarDirectoryPath: /var/lib/kubelet/plugins_registry | ||
| kubeletPluginsDirectoryPath: /var/lib/kubelet/plugins | ||
| enableDeviceMetadata: false |
There was a problem hiding this comment.
Can we update the e2e tests to enable and exercise this flag?
#153 refactors all of the e2e logic but I think that will merge soon, so you may want to hold off on that until that merges.
Co-authored-by: alaypatel07 <alayp@nvidia.com> Signed-off-by: carlory <baofa.fan@daocloud.io>
…ce attributes from the allocatable device pool through to prepared devices. This includes a new --enable-device-metadata flag and corresponding Helm chart value. Signed-off-by: carlory <baofa.fan@daocloud.io>
77ab291 to
b032b4e
Compare
| # The kubernetes tag to build the kind cluster from | ||
| # From ${KIND_K8S_REPO}/tags | ||
| : ${KIND_K8S_TAG:="v1.35.0"} | ||
| : ${KIND_K8S_TAG:="v1.36.0"} |
There was a problem hiding this comment.
v1.36.0 is unavailable.
~ » skopeo list-tags docker://docker.io/kindest/node | jq '.Tags[-1]' kiki@zhanxis-MacBook-Pro
"v1.35.1"
There was a problem hiding this comment.
We could set BUILD_KIND_IMAGE based on whether $KIND_IMAGE exists instead of a static true/false.
dra-example-driver/demo/scripts/common.sh
Lines 41 to 44 in a538bc8
I've noticed resource constraint issues with building the kind image from source in CI. Then we could refactor demo/scripts/build-kind-image.sh to allow building the image from release artifacts. We would need a way to pass --type release <version> here instead of a file path to the cloned repo:
A generic variable like KIND_BUILD_NODE_IMAGE_ARGS is probably good enough to handle a variety of use cases.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
Add support for KEP-5304 in-container device metadata by passing device attributes from the allocatable device pool through to prepared devices.
--enable-device-metadataCLI flag andENABLE_DEVICE_METADATAenv varkubeletPlugin.enableDeviceMetadataHelm chart value/cc @alaypatel07
I add you as co-author. If you want to submit a PR, feel free to close this PR.