Skip to content

Commit 936939e

Browse files
committed
Use 429 (TooManyRequests) instead of 503 for eviction ImmediateResponse
Signed-off-by: RishabhSaini <rishabhsaini01@gmail.com>
1 parent 654ab49 commit 936939e

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

pkg/epp/handlers/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ func (s *StreamingServer) recvOrAbort(
394394
Response: &extProcPb.ProcessingResponse_ImmediateResponse{
395395
ImmediateResponse: &extProcPb.ImmediateResponse{
396396
Status: &envoyTypePb.HttpStatus{
397-
Code: envoyTypePb.StatusCode_ServiceUnavailable,
397+
Code: envoyTypePb.StatusCode_TooManyRequests,
398398
},
399399
Body: []byte("request evicted by flow control"),
400400
},

pkg/epp/handlers/server_abort_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ func TestRecvOrAbort_AbortBeforeRecv(t *testing.T) {
112112
case sent := <-srv.sentCh:
113113
ir := sent.GetImmediateResponse()
114114
require.NotNil(t, ir, "Should have sent ImmediateResponse")
115-
assert.Equal(t, envoyTypePb.StatusCode_ServiceUnavailable, ir.Status.Code)
115+
assert.Equal(t, envoyTypePb.StatusCode_TooManyRequests, ir.Status.Code)
116116
assert.Equal(t, []byte("request evicted by flow control"), ir.Body)
117117
case <-time.After(time.Second):
118118
t.Fatal("Timeout waiting for ImmediateResponse")
@@ -143,7 +143,7 @@ func TestRecvOrAbort_AbortDuringRecvWait(t *testing.T) {
143143
case sent := <-srv.sentCh:
144144
ir := sent.GetImmediateResponse()
145145
require.NotNil(t, ir)
146-
assert.Equal(t, envoyTypePb.StatusCode_ServiceUnavailable, ir.Status.Code)
146+
assert.Equal(t, envoyTypePb.StatusCode_TooManyRequests, ir.Status.Code)
147147
case <-time.After(time.Second):
148148
t.Fatal("Timeout waiting for ImmediateResponse")
149149
}

0 commit comments

Comments
 (0)