-
Notifications
You must be signed in to change notification settings - Fork 729
ProtocolType may not work as expected because of the case #3184
Copy link
Copy link
Open
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.triage/needs-informationIndicates an issue needs more information in order to work on it.Indicates an issue needs more information in order to work on it.
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.triage/needs-informationIndicates an issue needs more information in order to work on it.Indicates an issue needs more information in order to work on it.
Type
Fields
Give feedbackNo fields configured for issues without a type.
What happened:
Provide a configuration like:
The result is that this resource is accepted (because "tcp" is valid protocol name), but doesn't treat it as TCP protocol (because it is not equal to TCPProtocolType constant).
What you expected to happen:
Either this resource is rejected (because the TCP protocol name is "TCP", no "tcp"), or handle it as TCP protocol.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
IMHO, we can either require the ProtocolType to be treated as case-insensitive, or require all Core protocols to be uppercase.