Bump ansible-lint to v25.2.0

[ffais]

Change description

Upgrade ansible-lint to a newer version 25.2.0.

There're some rule violations with the new version, some of these are easily fixable, while others should be added to the ignore file. Do you think these changes should be made in this PR or in a dedicated one? @drew-viles @mboersma

# Rule Violation Summary
  6 command-instead-of-module profile:basic tags:command-shell,idiom
 11 command-instead-of-shell profile:basic tags:command-shell,idiom
  4 jinja profile:basic tags:formatting
  3 schema profile:basic tags:core
 89 name profile:basic tags:idiom
  3 name profile:basic tags:idiom
 86 var-naming profile:basic tags:idiom
 10 yaml profile:basic tags:formatting,yaml
  1 name profile:basic tags:idiom
  5 package-latest profile:basic tags:idempotency
  1 ignore-errors profile:basic tags:unpredictability
 60 no-changed-when profile:basic tags:command-shell,idempotency

Related issues

• Fixes Update ansible-lint to a newer version #1928

This is a copy of #1935 that was closed by mistake.

[k8s-ci-robot]

Hi @ffais. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-triage-robot]

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

[mboersma]

/ok-to-test

Do you think these changes should be made in this PR or in a dedicated one?

I think this is great as-is. We can open further PRs to fix linter errors and remove them from the ignore file.

[mboersma]

/retest

403 rate limiting error.

[ffais]

Now the download of containerd is failing.

/test pull-gcp-all

[ffais]

/test pull-gcp-all

[ffais]

I really don't understand why google is failing.

[mboersma]

/retest

[mboersma]

/lgtm
/approve

Thanks @ffais! Sorry for the delay.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mboersma]

/override pull-azure-vhds

Transient network error downloading crictl for azl3.

[k8s-ci-robot]

@mboersma: Overrode contexts on behalf of mboersma: pull-azure-vhds

Details

In response to this:

/override pull-azure-vhds

Transient network error downloading crictl for azl3.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.