feat(outscale): Add Flatcar and NVIDIA GPU support#1986
Conversation
|
Hi @hajowieland. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
|
||
| The following additional environment variables are required for Flatcar builds: | ||
| ``` | ||
| FLATCAR_CHANNEL: Flatcar release channel (stable, beta, alpha). Defaults to stable. |
There was a problem hiding this comment.
The docs say here "Defaults to stable" but I don't see a default set anywhere, just the user var in packer-flatcar.json. Same for FLATCAR_VERSION.
Could you set a safe default in install-flatcar.sh itself?
FLATCAR_CHANNEL="${FLATCAR_CHANNEL:-stable}"
FLATCAR_VERSION="${FLATCAR_VERSION:-current}"or change the documentation so it doesn't imply there's a default.
Change description
This change adds support for Flatcar Linux on Outscale with optional NVIDIA GPU support (via sysext).
Additional context
The change was tested with GPU and without. Also the Cluster API Provider Outscale needs to be updated to support Ignition.