Skip to content

feat(outscale): Add Flatcar and NVIDIA GPU support#1986

Open
hajowieland wants to merge 4 commits into
kubernetes-sigs:mainfrom
hajowieland:outscale-flatcar
Open

feat(outscale): Add Flatcar and NVIDIA GPU support#1986
hajowieland wants to merge 4 commits into
kubernetes-sigs:mainfrom
hajowieland:outscale-flatcar

Conversation

@hajowieland
Copy link
Copy Markdown
Contributor

Change description

This change adds support for Flatcar Linux on Outscale with optional NVIDIA GPU support (via sysext).

  • Is this change including a new Provider or a new OS? (y/n) n
  • If yes, has the Provider/OS matrix been updated in the readme? (y/n) y
  • If adding a new provider, are you a representative of that provider? (y/n) n

Additional context

The change was tested with GPU and without. Also the Cluster API Provider Outscale needs to be updated to support Ignition.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @hajowieland. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 23, 2026
@mboersma
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2026
@mboersma mboersma requested review from drew-viles and removed request for jsturtevant April 27, 2026 16:02
Copy link
Copy Markdown
Contributor

@drew-viles drew-viles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the JSON sort, lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2026
@drew-viles drew-viles removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from drew-viles. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@drew-viles
Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@mboersma
Copy link
Copy Markdown
Contributor

/retest


The following additional environment variables are required for Flatcar builds:
```
FLATCAR_CHANNEL: Flatcar release channel (stable, beta, alpha). Defaults to stable.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs say here "Defaults to stable" but I don't see a default set anywhere, just the user var in packer-flatcar.json. Same for FLATCAR_VERSION.

Could you set a safe default in install-flatcar.sh itself?

FLATCAR_CHANNEL="${FLATCAR_CHANNEL:-stable}"
FLATCAR_VERSION="${FLATCAR_VERSION:-current}"

or change the documentation so it doesn't imply there's a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants