Remove dead python2 references#2000
Conversation
These references target RHEL/CentOS 7 and 8, which are no longer build targets in image-builder (the README lists only RHEL 9, Rocky 9, AlmaLinux 9, CentOS 9). The python2-pip install task in vmware-redhat.yml was gated on distribution_major_version <= 8, and the pip<21.0 upgrade was gated on == 7; both conditions are now unreachable. The python2-pip entries in goss-vars.yaml were similarly unused. Refs: kubernetes-sigs#578
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@mboersma: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Change description
Cleanup of dead
python2references that target RHEL/CentOS 7 and 8 — neither of which are build targets in image-builder anymore (the README only listsrhel-9,rockylinux-9,almalinux-9,centos-9, andMakefilehas no*-7/*-8entries).Removes:
roles/providers/tasks/vmware-redhat.yml: theInstall python2 piptask (gated ondistribution_major_version <= 8) and theUpgrade piptask (gated on== 7). Both conditions are now unreachable.packer/goss/goss-vars.yaml: fourpython2-pip:entries (two ungated undercentos:, two underdistro_version: "8"blocks).make lintpasses cleanly.Related issues
Additional context
No behavior change for any currently-built distro. Easy revert if desired.