Skip to content

Remove dead python2 references#2000

Open
mboersma wants to merge 1 commit intokubernetes-sigs:mainfrom
mboersma:cleanup-dead-python2-refs
Open

Remove dead python2 references#2000
mboersma wants to merge 1 commit intokubernetes-sigs:mainfrom
mboersma:cleanup-dead-python2-refs

Conversation

@mboersma
Copy link
Copy Markdown
Contributor

@mboersma mboersma commented May 8, 2026

Change description

Cleanup of dead python2 references that target RHEL/CentOS 7 and 8 — neither of which are build targets in image-builder anymore (the README only lists rhel-9, rockylinux-9, almalinux-9, centos-9, and Makefile has no *-7/*-8 entries).

Removes:

  • roles/providers/tasks/vmware-redhat.yml: the Install python2 pip task (gated on distribution_major_version <= 8) and the Upgrade pip task (gated on == 7). Both conditions are now unreachable.
  • packer/goss/goss-vars.yaml: four python2-pip: entries (two ungated under centos:, two under distro_version: "8" blocks).

make lint passes cleanly.

  • Is this change including a new Provider or a new OS? (y/n) n

Related issues

  • Closes Remove python2 from CAPI Photon images #578 (no longer applicable — Photon 3 has been removed entirely; current Photon 4/5 paths already use python3 only — but this PR cleans up the unrelated python2 cruft that lingered elsewhere)

Additional context

No behavior change for any currently-built distro. Easy revert if desired.

These references target RHEL/CentOS 7 and 8, which are no longer build
targets in image-builder (the README lists only RHEL 9, Rocky 9, AlmaLinux
9, CentOS 9). The python2-pip install task in vmware-redhat.yml was gated
on distribution_major_version <= 8, and the pip<21.0 upgrade was gated on
== 7; both conditions are now unreachable. The python2-pip entries in
goss-vars.yaml were similarly unused.

Refs: kubernetes-sigs#578
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ova-all 7e4c97c link false /test pull-ova-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove python2 from CAPI Photon images

2 participants