Skip to content

Remove dead RHEL/CentOS 8 entries from goss-vars#2002

Open
mboersma wants to merge 1 commit intokubernetes-sigs:mainfrom
mboersma:cleanup-goss-vars-rhel8
Open

Remove dead RHEL/CentOS 8 entries from goss-vars#2002
mboersma wants to merge 1 commit intokubernetes-sigs:mainfrom
mboersma:cleanup-goss-vars-rhel8

Conversation

@mboersma
Copy link
Copy Markdown
Contributor

@mboersma mboersma commented May 8, 2026

Change description

Removes dead distro_version: "8" blocks from images/capi/packer/goss/goss-vars.yaml. These goss test entries are unreachable: image-builder no longer has any *-8 build targets — Makefile and the README matrix only reference rhel-9, rockylinux-9, almalinux-9, and centos-9.

Also drops a few empty os_version: keys left behind after removing the only child entry, and deletes a couple of python2-pip: entries that lived inside the removed blocks (also covered by #2000 in the lines outside these blocks).

The rh8_rpms YAML alias itself is kept because the oracle linux:oci block still references it; all five packages it lists (curl, yum-utils, nftables, python3-netifaces, python3-requests) are valid on Oracle Linux 9, so goss behavior for oci-oracle-linux-9 is unchanged.

  • Is this change including a new Provider or a new OS? (y/n) n

Related issues

Additional context

YAML structure validated locally with yaml.safe_load. No behavior change for any currently-built distro.

These distro_version: "8" blocks (and a couple of related python2-pip
entries) are unreachable: image-builder no longer ships any *-8 build
targets, only the *-9 variants in the README matrix and Makefile.

Also drops a few empty 'os_version:' keys left behind after removing
the only child entry. The 'rh8_rpms' YAML alias is kept because Oracle
Linux 9's OCI block still references it (and 'curl', 'yum-utils',
'nftables', 'python3-netifaces', 'python3-requests' are all valid on
OL 9, so behavior is unchanged).
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign averagemarcus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ova-all a6cd765 link false /test pull-ova-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants