Remove dead RHEL/CentOS 8 entries from goss-vars#2002
Remove dead RHEL/CentOS 8 entries from goss-vars#2002mboersma wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
These distro_version: "8" blocks (and a couple of related python2-pip entries) are unreachable: image-builder no longer ships any *-8 build targets, only the *-9 variants in the README matrix and Makefile. Also drops a few empty 'os_version:' keys left behind after removing the only child entry. The 'rh8_rpms' YAML alias is kept because Oracle Linux 9's OCI block still references it (and 'curl', 'yum-utils', 'nftables', 'python3-netifaces', 'python3-requests' are all valid on OL 9, so behavior is unchanged).
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@mboersma: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Change description
Removes dead
distro_version: "8"blocks fromimages/capi/packer/goss/goss-vars.yaml. These goss test entries are unreachable: image-builder no longer has any*-8build targets —Makefileand the README matrix only referencerhel-9,rockylinux-9,almalinux-9, andcentos-9.Also drops a few empty
os_version:keys left behind after removing the only child entry, and deletes a couple ofpython2-pip:entries that lived inside the removed blocks (also covered by #2000 in the lines outside these blocks).The
rh8_rpmsYAML alias itself is kept because theoracle linux:ociblock still references it; all five packages it lists (curl,yum-utils,nftables,python3-netifaces,python3-requests) are valid on Oracle Linux 9, so goss behavior foroci-oracle-linux-9is unchanged.Related issues
Additional context
YAML structure validated locally with
yaml.safe_load. No behavior change for any currently-built distro.