feat: adding containerd_enable_limit_no_file as an option to allow users to add this file on demand as required.#2004
Conversation
…ers to add this file on demand as required. We still keep the original parameters but are adding an OR option for this so we can use it in a wider scope - defaulting the option to false. Also adding goss checks for this.
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-azure-sigs |
|
/override pull-ova-all Known iptables photon-5 build failure. |
|
@drew-viles: Overrode contexts on behalf of drew-viles: pull-ova-all DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@drew-viles: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Change description
I've hit an issue in our OpenStack image builds where we need this enabling but it's currently conditionally enabled for Marina, Flatcar or Azure.
This adds a new OR condition to allow people to enable this on more than those three options. Rather than changing the flow, which would break existing users implementation, adding the OR made more sense to prevent a regression.
The default for this new value is false to keep everything as it is now and making it purely opt-in.
Added Goss tests and udpated the docs too.