Skip to content

Ubuntu 2404 cloud-image#2016

Open
zrk02 wants to merge 1 commit into
kubernetes-sigs:mainfrom
elastx:ubuntu_2404_cloudimage
Open

Ubuntu 2404 cloud-image#2016
zrk02 wants to merge 1 commit into
kubernetes-sigs:mainfrom
elastx:ubuntu_2404_cloudimage

Conversation

@zrk02

@zrk02 zrk02 commented May 20, 2026

Copy link
Copy Markdown

Change description

Following the tradition from Ubuntu 22 cloud-image, somehow the Ubuntu 24 was introduced 2 years ago, non-cloudimage.
This PR brings Ubuntu 24 cloud image, following closely the pattern from Ubuntu 22.

Notes

There are a few delay tweaks to improve the reliabilty to successfully start, handling race conditions.

- Is this change including a new Provider or a new OS? (y/n)
- "No" - Ubuntu 24.04 is already there, this is another imagetype.
- If yes, has the Provider/OS matrix been updated in the readme? (y/n)
- "no" - Ubuntu 24.04 already is present. Ubuntu 22.04 using cloud-image was not specified as cloud-image.
- If adding a new provider, are you a representative of that provider? (y/n)
-Not relevant.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign averagemarcus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla

linux-foundation-easycla Bot commented May 20, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested a review from yadvr May 20, 2026 12:36
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @zrk02!

It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @zrk02. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2026
@drew-viles

Copy link
Copy Markdown
Contributor

Please sign the easy CLA before we move forward with this PR. Thanks!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 28, 2026
@zrk02

zrk02 commented Jun 1, 2026

Copy link
Copy Markdown
Author

CLA signed.
I also see a label about merge-commits being present.

Following https://github.com/kubernetes/community/blob/main/contributors/guide/contributor-cheatsheet/README.md#squashing-commits

I'm still awaiting further triage.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2026
@zrk02 zrk02 force-pushed the ubuntu_2404_cloudimage branch from 53c4db8 to 400919f Compare June 5, 2026 12:11
@k8s-ci-robot k8s-ci-robot removed do-not-merge/contains-merge-commits needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 5, 2026
@drew-viles

drew-viles commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

@zrk02 I'm happy to start the testing, but can you squash your commits? (that should help remove the merge commits)

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2026
@zrk02 zrk02 force-pushed the ubuntu_2404_cloudimage branch from 400919f to e11999d Compare June 8, 2026 14:20
Adds a QEMU build for the Ubuntu 24.04 (noble) cloud image, mirroring
the existing qemu-ubuntu-2204-cloudimg pattern.

- Add qemu-ubuntu-2404-cloudimg make targets (appended to
  QEMU_BUILD_NAMES with build/validate help lines).
- Add packer/qemu/qemu-ubuntu-2404-cloudimg.json using noble URLs.
- Add wait_for_cloudinit and extra_reboot_timeout user variables to
  the qemu packer template. Both default to no-ops so non-cloudimg
  builds are unaffected; only this build opts in. Cloud-image QEMU
  builds need to wait for cloud-init to finish before further
  provisioning, and the post-install reboot can exceed the default
  packer timeout.
- Use a 24.04-specific cloud-init dir carrying the canonical
  underscore 'lock_passwd' key. Upstream's shared user-data.tmpl uses
  the deprecated hyphenated 'lock-passwd' (deprecated in cloud-init
  22.3); cloud-init 24.x counts the deprecation as a recoverable_error
  so 'cloud-init status --wait' exits 2 even when final status is
  'done', which fails our wait_for_cloudinit provisioner running under
  'bash -e'.
- Set extra_reboot_timeout to 90s: in concurrent CI runs the nested
  QEMU VM's sshd is sometimes not reachable within the default pause,
  causing packer 'connection reset by peer' errors.

Signed-off-by: zrk02 <johan.suurkula@elastx.se>
@zrk02 zrk02 force-pushed the ubuntu_2404_cloudimage branch from e11999d to 7db58c7 Compare June 8, 2026 14:21
@zrk02

zrk02 commented Jun 8, 2026

Copy link
Copy Markdown
Author

Im suggesting a retest since it failed at a short glitch in this step:

    googlecompute.ubuntu-2604: TASK [kubernetes : Download crictl] ********************************************
    googlecompute.ubuntu-2604: fatal: [default]: FAILED! => {"changed": false, "dest": "/tmp/crictl-v1.34.0-linux-amd64.tar.gz", "elapsed": 0, "msg": "Request failed", "response": "HTTP Error 500: Internal Server Error", "status_code": 500, "url": "https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.34.0/crictl-v1.34.0-linux-amd64.tar.gz"}

/retest-required

@zrk02

zrk02 commented Jun 9, 2026

Copy link
Copy Markdown
Author

The Azure e2e failed only on sig-ubuntu-2604 / sig-ubuntu-2604-gen2 — the Ubuntu 26.04 builds from #1987, which look broken on main. This PR is QEMU-only and touches nothing in the Azure/2604 path; all 24.04 targets passed.

sig-ubuntu-2604-gen2: FAILED. See logs in the artifacts folder.  <<<<<<<<<<<<<<<<<<<<<<<<<
sig-windows-2022-containerd-cvm: SUCCESS
sig-azurelinux-3: SUCCESS
sig-windows-2022-containerd: SUCCESS
sig-windows-2025-containerd: SUCCESS
sig-flatcar-gen2: SUCCESS
sig-ubuntu-2204: SUCCESS
sig-ubuntu-2404-cvm: SUCCESS
sig-ubuntu-2404: SUCCESS
sig-ubuntu-2204-gen2: SUCCESS
sig-flatcar: SUCCESS
sig-azurelinux-3-gen2: SUCCESS
sig-ubuntu-2604: FAILED. See logs in the artifacts folder. <<<<<<<<<<<<<<<<<<<<<<<<<
sig-ubuntu-2404-gen2: SUCCESS

I'm hesitant the test can pass without some additional work to clean up main, in the wake of: #1987

I'll trigger a retest for good measure.

/retest-required

@zrk02

zrk02 commented Jun 10, 2026

Copy link
Copy Markdown
Author

I don't think I can do more from this PR.

Tests seems to be deadlocked until another issue is fixed with Ubuntu 26, that seems to have made it's way into Main prematurely.

All tests related to Ubuntu 24 passes.

Can this be merged as is?
@mboersma
@Whisper40

(In the meanwhile, I'll start poking to the underlying issue for another PR).

@Whisper40

Whisper40 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@zrk02 Ubuntu26 build was working properly when merged. I will try to have a look

sig-ubuntu-2404-cvm: FAILED. See logs in the artifacts folder.
sig-ubuntu-2204-gen2: FAILED. See logs in the artifacts folder.
sig-ubuntu-2604: FAILED. See logs in the artifacts folder.

@Whisper40

Copy link
Copy Markdown
Contributor

/retest

@Whisper40

Copy link
Copy Markdown
Contributor

@zrk02 as you can see build is now a success, the CI is failing a lot for a lot of cases not related to the project itself ..

@zrk02

zrk02 commented Jun 10, 2026

Copy link
Copy Markdown
Author

@zrk02 as you can see build is now a success, the CI is failing a lot for a lot of cases not related to the project itself ..

Excellent. Thank you.
This is my first contribution, and thus a little bit 'klonky'.

What's the next step?
My interpretation is just to await an approve/lgtm flag?

@mboersma mboersma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have CI that covers QEMU, so if you could verify somehow that you've been able to build from this branch locally, that would inspire confidence.

Sorry about the Azure flakes, it's nothing you've done. Thanks for doing this!

],
"provisioners": [
{
"expect_disconnect": true,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably harmless but misleading, because this step doesn't reboot or disconnect as far as I'm aware.

@kubernetes-prow kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants