Ubuntu 2404 cloud-image#2016
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @zrk02! |
|
Hi @zrk02. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Please sign the easy CLA before we move forward with this PR. Thanks! |
|
CLA signed. I'm still awaiting further triage. |
53c4db8 to
400919f
Compare
|
@zrk02 I'm happy to start the testing, but can you squash your commits? (that should help remove the merge commits) /ok-to-test |
400919f to
e11999d
Compare
Adds a QEMU build for the Ubuntu 24.04 (noble) cloud image, mirroring the existing qemu-ubuntu-2204-cloudimg pattern. - Add qemu-ubuntu-2404-cloudimg make targets (appended to QEMU_BUILD_NAMES with build/validate help lines). - Add packer/qemu/qemu-ubuntu-2404-cloudimg.json using noble URLs. - Add wait_for_cloudinit and extra_reboot_timeout user variables to the qemu packer template. Both default to no-ops so non-cloudimg builds are unaffected; only this build opts in. Cloud-image QEMU builds need to wait for cloud-init to finish before further provisioning, and the post-install reboot can exceed the default packer timeout. - Use a 24.04-specific cloud-init dir carrying the canonical underscore 'lock_passwd' key. Upstream's shared user-data.tmpl uses the deprecated hyphenated 'lock-passwd' (deprecated in cloud-init 22.3); cloud-init 24.x counts the deprecation as a recoverable_error so 'cloud-init status --wait' exits 2 even when final status is 'done', which fails our wait_for_cloudinit provisioner running under 'bash -e'. - Set extra_reboot_timeout to 90s: in concurrent CI runs the nested QEMU VM's sshd is sometimes not reachable within the default pause, causing packer 'connection reset by peer' errors. Signed-off-by: zrk02 <johan.suurkula@elastx.se>
e11999d to
7db58c7
Compare
|
Im suggesting a retest since it failed at a short glitch in this step: /retest-required |
|
The Azure e2e failed only on sig-ubuntu-2604 / sig-ubuntu-2604-gen2 — the Ubuntu 26.04 builds from #1987, which look broken on main. This PR is QEMU-only and touches nothing in the Azure/2604 path; all 24.04 targets passed. I'm hesitant the test can pass without some additional work to clean up main, in the wake of: #1987 I'll trigger a retest for good measure. /retest-required |
|
I don't think I can do more from this PR. Tests seems to be deadlocked until another issue is fixed with Ubuntu 26, that seems to have made it's way into Main prematurely. All tests related to Ubuntu 24 passes. Can this be merged as is? (In the meanwhile, I'll start poking to the underlying issue for another PR). |
|
@zrk02 Ubuntu26 build was working properly when merged. I will try to have a look sig-ubuntu-2404-cvm: FAILED. See logs in the artifacts folder. |
|
/retest |
|
@zrk02 as you can see build is now a success, the CI is failing a lot for a lot of cases not related to the project itself .. |
Excellent. Thank you. What's the next step? |
mboersma
left a comment
There was a problem hiding this comment.
We don't have CI that covers QEMU, so if you could verify somehow that you've been able to build from this branch locally, that would inspire confidence.
Sorry about the Azure flakes, it's nothing you've done. Thanks for doing this!
| ], | ||
| "provisioners": [ | ||
| { | ||
| "expect_disconnect": true, |
There was a problem hiding this comment.
This is probably harmless but misleading, because this step doesn't reboot or disconnect as far as I'm aware.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Change description
Following the tradition from Ubuntu 22 cloud-image, somehow the Ubuntu 24 was introduced 2 years ago, non-cloudimage.
This PR brings Ubuntu 24 cloud image, following closely the pattern from Ubuntu 22.
Notes
There are a few delay tweaks to improve the reliabilty to successfully start, handling race conditions.
- Is this change including a new Provider or a new OS? (y/n)
- "No" - Ubuntu 24.04 is already there, this is another imagetype.
- If yes, has the Provider/OS matrix been updated in the readme? (y/n)
- "no" - Ubuntu 24.04 already is present. Ubuntu 22.04 using cloud-image was not specified as cloud-image.
- If adding a new provider, are you a representative of that provider? (y/n)
-Not relevant.