Fix hub webhook DRA version gating to skip cluster version check#1286
Merged
k8s-ci-robot merged 1 commit intoJun 14, 2026
Merged
Conversation
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomerNewman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1286 +/- ##
==========================================
- Coverage 79.09% 73.39% -5.70%
==========================================
Files 51 67 +16
Lines 5109 4921 -188
==========================================
- Hits 4041 3612 -429
- Misses 882 1140 +258
+ Partials 186 169 -17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The ManagedClusterModule webhook on the hub was incorrectly using the hub cluster's Kubernetes version to gate DRA usage. Since the hub cannot know the target managed cluster's version, this could wrongly reject valid specs or accept invalid ones. Fix by passing an empty KubeVersion to the hub validator and skipping the version gate in validateDRA when the version is zero. Field format validation (driverName, deviceClasses) still runs unconditionally. The spoke cluster's own Module webhook enforces the version requirement. Also moves DiscoverKubeVersion inside the enableModule branch so that webhook modes that don't need cluster version (namespace, preflight) no longer require ClusterVersion API access.
TomerNewman
force-pushed
the
fix-hub-dra-version-gating
branch
from
a156105 to
e6f1373
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ManagedClusterModule webhook on the hub was incorrectly using the hub cluster's Kubernetes version to gate DRA usage. Since the hub cannot know the target managed cluster's version, this could wrongly reject valid specs or accept invalid ones.
Fix by passing an empty KubeVersion to the hub validator and skipping the version gate in validateDRA when the version is zero. Field format validation (driverName, deviceClasses) still runs unconditionally. The spoke cluster's own Module webhook enforces the version requirement.
Also moves DiscoverKubeVersion inside the enableModule branch so that webhook modes that don't need cluster version (namespace, preflight) no longer require ClusterVersion API access.
/cc @yevgeny-shnaidman
/assign @yevgeny-shnaidman