Register DRA reconciler with manager by TomerNewman · Pull Request #1287 · kubernetes-sigs/kernel-module-management

TomerNewman · 2026-06-16T15:04:40Z

Register DRA reconciler with manager

Summary

Wire the existing DRA reconciler into the operator manager so that DRA Modules
are actively reconciled when the manager runs in a cluster. This adds the scheme
registration, RBAC permissions, reconciler construction, and DRA module count
metric to the existing metrics sweep.

Changes

cmd/manager/main.go:
- Add resourcev1.AddToScheme(scheme) for the DRA resource API
- Construct and register DRAReconciler via SetupWithManager
internal/controllers/dra_reconciler.go:
- Add //+kubebuilder:rbac annotation for resource.k8s.io/deviceclasses
internal/metrics/metrics.go:
- Add SetKMMDRANum method and kmm_dra_num gauge
internal/controllers/device_plugin_reconciler.go:
- Count modules with spec.dra in the existing metrics sweep
config/rbac/role.yaml:
- Regenerated with resource.k8s.io/deviceclasses rule (all CRUD verbs)

Testing

Unit tests: Extended the setKMMOMetrics DescribeTable with a dra bool parameter and a new "dra" entry. All 12 entries (including "altogether") pass.
Integration tests: N/A
Coverage: setKMMOMetrics function at 100% coverage; internal/controllers package at 89.9%

Acceptance Criteria

AC-1: resourcev1.AddToScheme(scheme) is called in cmd/manager/main.go
AC-2: DRAReconciler is constructed and registered via SetupWithManager(mgr) in cmd/manager/main.go
AC-3: ClusterRole manifest includes resource.k8s.io/deviceclasses verbs (get, list, watch, create, update, patch, delete)
AC-4: DRA module count is reported in existing metrics sweep
AC-5: All unit tests pass; no duplicate reconciler registration

k8s-ci-robot · 2026-06-16T15:04:43Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

netlify · 2026-06-16T15:04:48Z

✅ Deploy Preview for kubernetes-sigs-kmm ready!

Name	Link
🔨 Latest commit	`61d35cd`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kmm/deploys/6a325e3e16ec140008db0565
😎 Deploy Preview	https://deploy-preview-1287--kubernetes-sigs-kmm.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot · 2026-06-16T15:04:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomerNewman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [TomerNewman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov-commenter · 2026-06-16T15:08:18Z

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.46%. Comparing base (fa23a9b) to head (61d35cd).
⚠️ Report is 384 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/manager/main.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
- Coverage   79.09%   73.46%   -5.64%     
==========================================
  Files          51       67      +16     
  Lines        5109     4993     -116     
==========================================
- Hits         4041     3668     -373     
- Misses        882     1156     +274     
+ Partials      186      169      -17

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TomerNewman · 2026-06-16T15:14:36Z

/uncc @mresvanis

yevgeny-shnaidman · 2026-06-16T16:33:39Z

 		cmd.FatalError(setupLogger, err, "unable to create controller", "name", controllers.DevicePluginPodReconcilerName)
 	}

+	drac := controllers.NewDRAReconciler(client, nodeAPI, scheme)


nit: lets do it the same way we do with NewDevicePluginPodReconciler, NewWorkerPodManager, etc'

yevgeny-shnaidman · 2026-06-16T16:34:21Z

+  - list
+  - patch
+  - update
+  - watch


do we need watch?

yevgeny-shnaidman · 2026-06-16T16:35:52Z

 	numModulesWithBuild := 0
 	numModulesWithSign := 0
 	numModulesWithDevicePlugin := 0
+	numModulesWithDRA := 0


lets not mix apples and oranges: i think that metrics changes should be done in a different PR

TomerNewman · 2026-06-17T05:54:41Z

Addressed all review comments @yevgeny-shnaidman :

Inline construction — done, matches the NewDevicePluginPodReconciler pattern.
Remove watch — removed watch and list from deviceclasses RBAC. The DRA reconciler only does get/create/update/patch/delete on DeviceClass; it never watches them.
Metrics in separate PR — removed all metrics changes from this PR. Will add them in a follow-up.

yevgeny-shnaidman · 2026-06-17T06:36:15Z

@TomerNewman this note is probably not for this PR, but since DRAReconciler is creating the DeviceClass, it should also probably watch them and respond to their events

TomerNewman · 2026-06-17T06:54:05Z

@TomerNewman this note is probably not for this PR, but since DRAReconciler is creating the DeviceClass, it should also probably watch them and respond to their events

its in here
#1288

TomerNewman · 2026-06-17T07:42:34Z

/hold
lets wait for #1288

Wire the DRA reconciler into the operator manager: - Add resourcev1.AddToScheme to register the DRA resource API - Construct and register DRAReconciler via SetupWithManager - Add RBAC annotation for resource.k8s.io/deviceclasses - Add DRA module count to the existing metrics sweep - Regenerate RBAC manifests and metrics mock

TomerNewman · 2026-06-17T08:27:48Z

/unhold
works locally, we can merge @yevgeny-shnaidman

yevgeny-shnaidman · 2026-06-17T08:41:11Z

/lgtm

TomerNewman · 2026-06-17T08:43:07Z

/hold

TomerNewman · 2026-06-17T08:44:17Z

/unhold

yevgeny-shnaidman · 2026-06-17T08:46:13Z

/lgtm

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2026

k8s-ci-robot requested review from mresvanis and ybettan June 16, 2026 15:04

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2026

TomerNewman force-pushed the MGMT-24472-register-dra-reconciler branch from beac291 to 7851a25 Compare June 16, 2026 15:11

TomerNewman marked this pull request as ready for review June 16, 2026 15:13

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2026

k8s-ci-robot requested a review from yevgeny-shnaidman June 16, 2026 15:14

k8s-ci-robot removed the request for review from mresvanis June 16, 2026 15:14

yevgeny-shnaidman reviewed Jun 16, 2026

View reviewed changes

TomerNewman force-pushed the MGMT-24472-register-dra-reconciler branch from 7851a25 to 1eac8a5 Compare June 17, 2026 05:54

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2026

TomerNewman force-pushed the MGMT-24472-register-dra-reconciler branch from 1eac8a5 to 2af8954 Compare June 17, 2026 06:33

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 17, 2026

TomerNewman force-pushed the MGMT-24472-register-dra-reconciler branch from 2af8954 to 9d682e6 Compare June 17, 2026 07:01

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2026

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2026

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2026

k8s-ci-robot assigned yevgeny-shnaidman Jun 17, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2026

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2026

TomerNewman force-pushed the MGMT-24472-register-dra-reconciler branch from 9d682e6 to 61d35cd Compare June 17, 2026 08:43

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2026

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2026

k8s-ci-robot merged commit 40f1f16 into kubernetes-sigs:main Jun 17, 2026
23 checks passed

TomerNewman mentioned this pull request Jun 23, 2026

Register DRA reconciler with manager rh-ecosystem-edge/kernel-module-management#1828

Merged

Uh oh!

Conversation

TomerNewman commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!