Add DeviceClass watch to DRA reconciler#1288
Merged
k8s-ci-robot merged 1 commit intoJun 17, 2026
Merged
Conversation
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomerNewman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
5 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1288 +/- ##
==========================================
- Coverage 79.09% 73.50% -5.59%
==========================================
Files 51 67 +16
Lines 5109 4990 -119
==========================================
- Hits 4041 3668 -373
- Misses 882 1153 +271
+ Partials 186 169 -17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
TomerNewman
force-pushed
the
dra-deviceclass-watch
branch
from
26a28fa to
78fa1ae
Compare
| ) | ||
| } | ||
|
|
||
| func deviceClassToModuleReconcileRequest(_ context.Context, obj client.Object) []reconcile.Request { |
Contributor
There was a problem hiding this comment.
lets move it to filter also
TomerNewman
force-pushed
the
dra-deviceclass-watch
branch
from
78fa1ae to
1191ccf
Compare
Watch DeviceClass resources so the controller reacts to external drift (e.g. manual deletion). Uses filter.HasLabel predicate to only process KMM-managed DeviceClasses. Also adds list, watch, and deletecollection RBAC verbs for the deviceclasses resource.
TomerNewman
force-pushed
the
dra-deviceclass-watch
branch
from
1191ccf to
0963150
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watch DeviceClass resources so the controller reacts to external drift (e.g. manual deletion). Uses filter.HasLabel predicate to only process KMM-managed DeviceClasses. Also adds list, watch, and deletecollection RBAC verbs for the deviceclasses resource.
/cc @yevgeny-shnaidman
/assign @yevgeny-shnaidman