Skip to content

Update docs to match port/protocol schema changes in v1alpha2#363

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
TheBeeZee:pr-ports-doc-update
Apr 8, 2026
Merged

Update docs to match port/protocol schema changes in v1alpha2#363
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
TheBeeZee:pr-ports-doc-update

Conversation

@TheBeeZee
Copy link
Copy Markdown
Contributor

@TheBeeZee TheBeeZee commented Mar 19, 2026 •
edited
Loading

Fixes: #358

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 19, 2026 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit abc9f64
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-network-policy-api/deploys/69d58d2723f9a50008ba1beb
😎 Deploy Preview https://deploy-preview-363--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 19, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 19, 2026

Hi @TheBeeZee. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2026
@TheBeeZee
Copy link
Copy Markdown
Contributor Author

TheBeeZee commented Mar 19, 2026

@bowei FYI

tssurya
tssurya requested changes Apr 5, 2026
View reviewed changes
Comment thread site-src/user-story-examples/user-story-3.yaml
Comment thread site-src/user-story-examples/user-story-3.yaml
Comment thread site-src/api-overview.md Outdated
Comment thread site-src/api-overview.md
Comment thread site-src/api-overview.md Outdated
@tssurya tssurya added this to the v1alpha2 milestone Apr 5, 2026
@TheBeeZee TheBeeZee force-pushed the pr-ports-doc-update branch from 4182ea8 to d05bd2e Compare April 6, 2026 16:58
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 6, 2026
@TheBeeZee TheBeeZee requested a review from tssurya April 6, 2026 16:58
@bowei
Copy link
Copy Markdown
Contributor

bowei commented Apr 7, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2026
@TheBeeZee
Update docs to match port/protocol schema changes in v1alpha2
abc9f64 
Signed-off-by: Blaz Zupan <blaz@google.com>
@TheBeeZee TheBeeZee force-pushed the pr-ports-doc-update branch from d05bd2e to abc9f64 Compare April 7, 2026 23:03
tssurya
tssurya approved these changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tssurya tssurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread npeps/npep-126-egress-traffic-control.md
workloads (non-hostNetworked pods) towards nodes in the
cluster is undefined. See https://github.com/kubernetes-sigs/network-policy-api/issues/73.
- ANP currently supports only east-west traffic and this traffic flow cuts from
- KCNP currently supports only east-west traffic and this traffic flow cuts from
Copy link
Copy Markdown
Contributor

@tssurya tssurya Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/KCNP/CNP

Comment thread npeps/npep-126-egress-traffic-control.md
- portNumber:
protocol: TCP
port: 6443
protocols:
Copy link
Copy Markdown
Contributor

@tssurya tssurya Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had only meant for changes to protocols :) but this works as well, thanks a lot for taking care of the other doc changes with references to older crds!

Comment thread npeps/npep-133-fqdn-egress-selector.md
@@ -29,20 +29,21 @@ Names](https://www.wikipedia.org/wiki/Fully_qualified_domain_name) (FQDNs).
belong to the domain. While this is definitely undesirable, it is at least
Copy link
Copy Markdown
Contributor

@tssurya tssurya Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for fdqn we were making the changes #366 but its fine I can rebase after this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheBeeZee, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2026
@k8s-ci-robot k8s-ci-robot merged commit b109128 into kubernetes-sigs:main Apr 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tssurya tssurya tssurya approved these changes

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@tssurya tssurya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1alpha2

Development

Successfully merging this pull request may close these issues.

Update docs to show the new updated protocol API

4 participants

@TheBeeZee @k8s-ci-robot @bowei @tssurya