Cut release v0.2.0#369
Merged
Merged
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
We had an API review meeting with thockin on 2nd April 2026 who approved the changes He has asked for more commented examples, tests for corner case scenarios which is captured kubernetes-sigs#365 but otherwise the API looks good Unfortunately since we didn't do a diff PR where Tim could comment, I had to use the last major API update PR 347 as the placeholder for approve which is hopefully fine. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
6a8df01 to
24f3050
Compare
Member
|
/lgtm |
TheBeeZee
approved these changes
Apr 21, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TheBeeZee, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had an API review meeting with thockin
on 2nd April 2026 who approved the changes
He has asked for more commented examples,
tests for corner case scenarios which is captured
#365 but otherwise the API looks good
Unfortunately since we didn't do a diff PR
where Tim could comment, I had to use the
last major API update PR 347 as the placeholder
for approve which is hopefully fine.
Marking as draft until we are sure we are good for release cut