nfd-worker: Add support to configure the ownerReference to Node by ozhuraki · Pull Request #2041 · kubernetes-sigs/node-feature-discovery

ozhuraki · 2025-02-05T17:47:10Z

Closes: #2039

k8s-ci-robot · 2025-02-05T17:47:20Z

Hi @ozhuraki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-02-05T17:47:21Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ozhuraki
Once this PR has been reviewed and has the lgtm label, please assign marquiz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2025-02-05T17:47:34Z

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	`24672b4`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/67ec1c7fc7835c0008df0186
😎 Deploy Preview	https://deploy-preview-2041--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

marquiz

Thanks @ozhuraki for this.

I started to wonder should we make this default behavior, instead, name the option OwnerRefPod (defaulting to false). In this case we'd also need to update the docs/deployment/uninstallation.md with instructions how to remove stale nodefeature objects. Probably update other pages as well (like docs/deployment/uninstallation.md#uninstallation) and note/warn about stale NodeFeature files after uninstallation.

/cc @ArangoGutierrez @adrianchiris @ahmetb
/ok-to-test

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>

ozhuraki · 2025-04-01T17:21:41Z

/retest-required

k8s-ci-robot · 2025-04-01T19:06:01Z

@ozhuraki: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-node-feature-discovery-e2e-test-master	`24672b4`	link	true	`/test pull-node-feature-discovery-e2e-test-master`
pull-node-feature-discovery-build-image-cross-generic	`24672b4`	link	true	`/test pull-node-feature-discovery-build-image-cross-generic`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-triage-robot · 2025-06-30T20:05:53Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-07-30T20:23:09Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

ahmetb · 2025-07-30T23:30:14Z

/lifecycle frozen

Still very much interested in this. 🙏

k8s-ci-robot · 2025-07-30T23:30:17Z

@ahmetb: The lifecycle/frozen label cannot be applied to Pull Requests.

Details

In response to this:

/lifecycle frozen

Still very much interested in this. 🙏

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-triage-robot · 2025-08-30T00:28:31Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2025-08-30T00:28:36Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-08-30T00:28:39Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

marquiz · 2025-09-01T08:12:21Z

/reopen
ping @ozhuraki

k8s-ci-robot · 2025-09-01T08:12:28Z

@marquiz: Reopened this PR.

Details

In response to this:

/reopen
ping @ozhuraki

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

marquiz · 2025-09-11T07:41:46Z

/remove-lifecycle rotten

marquiz · 2025-10-13T10:22:50Z

ping @ozhuraki, any update on this? I think this would still be a valuable enhancement (my comment still holds)

k8s-triage-robot · 2026-01-11T10:49:19Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ArangoGutierrez · 2026-01-15T11:01:27Z

/remove-lifecycle stale

k8s-triage-robot · 2026-04-15T11:37:50Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ArangoGutierrez

Sorry this sat so long — thanks for your patience. The feature itself makes sense and I'd like to land a version of it. A few things to work through:

The branch is behind master and needs a rebase; CI has gone red since April.
Main design question — see the inline note on setOwnerReference. This currently changes the default owner from Pod to Node, which is a behavior change on upgrade for existing users. I'd prefer keeping Pod as the default and making Node opt-in, and ideally collapsing the two booleans into a single -owner-ref=none|pod|node flag (deprecating -no-owner-refs). Happy to discuss alternatives.
The test update in nfd-worker_test.go sets NoOwnerRefs: true, which skips the new owner-ref logic entirely — we'd need tests that actually exercise the new Pod and Node paths.
Could you also add ownerRefPod to deployment/helm/node-feature-discovery/values.yaml? Helm users won't otherwise discover the new option.

If any of this is a non-starter for you, let me know — happy to talk it through.

ArangoGutierrez · 2026-04-23T13:40:11Z

-					owner.BlockOwnerDeletion = ptr.To(false)
-					ownerReference = append(ownerReference, owner)
+		if w.config.Core.OwnerRefPod {
+			// Get pod owner reference


Main concern with the current shape: wrapping the pre-existing Pod path in if OwnerRefPod and making Node the else flips the default owner from Pod to Node. Existing deployments upgrading would see their NodeFeature objects stop being owned by the worker Pod/DaemonSet.

Could we keep Pod as the default and make Node the opt-in? And, larger question: would you be open to a single enum flag -owner-ref=none|pod|node (deprecating -no-owner-refs) so we don't have two booleans encoding three states?

ArangoGutierrez · 2026-04-23T13:40:11Z

+					return err
+				} else {
+					ownerReference = append(ownerReference, metav1.OwnerReference{
+						APIVersion: "v1",


For the Node case, worth setting Controller and BlockOwnerDeletion explicitly — there's no other controller claiming NodeFeature, and being explicit matches the Pod branch and K8s conventions.

ArangoGutierrez · 2026-04-23T13:40:12Z

+			nodeName := os.Getenv("NODE_NAME")
+			if nodeName != "" {
+				if selfNode, err := w.k8sClient.CoreV1().Nodes().Get(context.TODO(), nodeName, metav1.GetOptions{}); err != nil {
+					klog.ErrorS(err, "failed to get self node, cannot inherit ownerReference for NodeFeature")


Small thing while we're here: could we thread a context.Context into this function instead of context.TODO()? Pre-existing on the Pod branch, nice to fix on the way through.

ArangoGutierrez · 2026-04-23T13:40:12Z

+			b := true
 			args := &worker.Args{
-				Oneshot: true,
+				Oneshot:     true,


Setting NoOwnerRefs: true here skips the new owner-ref logic entirely — the new code isn't exercised by any test. Could we add a table-driven test over the {none, pod, node} configurations, pre-creating a fake Node with a known UID and asserting the resulting OwnerReferences? That would also cover the Node-not-found error path.

ArangoGutierrez · 2026-04-23T13:40:12Z

+manually delete stale NodeFeature objects.
+
+```bash
+kubectl delete -n node-feature-discovery NodeFeature $(kubectl get -o json -n node-feature-discovery NodeFeature | jq ".items[].metadata.name")


Small fix: jq ".items[].metadata.name" emits quoted strings, which kubectl delete will reject. Two options — add -r to jq, or simpler: kubectl delete -n node-feature-discovery nodefeatures.nfd.k8s-sigs.io --all.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2025

k8s-ci-robot requested review from kad and marquiz February 5, 2025 17:47

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2025

marquiz reviewed Mar 28, 2025

View reviewed changes

k8s-ci-robot requested review from ArangoGutierrez, adrianchiris and ahmetb March 28, 2025 15:51

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2025

ozhuraki force-pushed the owner-ref-node branch 2 times, most recently from 6335e04 to 3e90be9 Compare March 31, 2025 18:46

nfd-worker: Add support to configure the ownerReference to Node

24672b4

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>

ozhuraki force-pushed the owner-ref-node branch from 3e90be9 to 24672b4 Compare April 1, 2025 17:03

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 30, 2025

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 30, 2025

k8s-ci-robot closed this Aug 30, 2025

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2025

k8s-ci-robot reopened this Sep 1, 2025

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 11, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 11, 2026

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2026

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2026

ArangoGutierrez requested changes Apr 23, 2026

View reviewed changes

Conversation

ozhuraki commented Feb 5, 2025

Uh oh!

k8s-ci-robot commented Feb 5, 2025

Uh oh!

k8s-ci-robot commented Feb 5, 2025

Uh oh!

netlify Bot commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Uh oh!

marquiz left a comment

Choose a reason for hiding this comment

Uh oh!

ozhuraki commented Apr 1, 2025

Uh oh!

k8s-ci-robot commented Apr 1, 2025

Uh oh!

k8s-triage-robot commented Jun 30, 2025

Uh oh!

k8s-triage-robot commented Jul 30, 2025

Uh oh!

ahmetb commented Jul 30, 2025

Uh oh!

k8s-ci-robot commented Jul 30, 2025

Uh oh!

k8s-triage-robot commented Aug 30, 2025

Uh oh!

k8s-ci-robot commented Aug 30, 2025

Uh oh!

k8s-ci-robot commented Aug 30, 2025

Uh oh!

marquiz commented Sep 1, 2025

Uh oh!

k8s-ci-robot commented Sep 1, 2025

Uh oh!

marquiz commented Sep 11, 2025

Uh oh!

marquiz commented Oct 13, 2025

Uh oh!

k8s-triage-robot commented Jan 11, 2026

Uh oh!

ArangoGutierrez commented Jan 15, 2026

Uh oh!

k8s-triage-robot commented Apr 15, 2026

Uh oh!

ArangoGutierrez left a comment

Choose a reason for hiding this comment

Uh oh!

ArangoGutierrez Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

ArangoGutierrez Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

ArangoGutierrez Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

ArangoGutierrez Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

ArangoGutierrez Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

netlify Bot commented Feb 5, 2025 •

edited

Loading