source/memory: Detect total memory#2465
source/memory: Detect total memory#2465ozhuraki wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ozhuraki The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @ozhuraki. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
marquiz
left a comment
There was a problem hiding this comment.
May I ask the rationale/use case for this feature? Memory is managed by K8s as native resources and information is available e.g. in Node status. Even though this is a relatively small change, we need a solid justification if we're to add it
No description provided.