Skip to content

kubectl-nfd: Add NodeFeatureGroup dryrun, validation and test#2474

Open
ozhuraki wants to merge 1 commit intokubernetes-sigs:masterfrom
ozhuraki:kubectl-nfd-nfg
Open

kubectl-nfd: Add NodeFeatureGroup dryrun, validation and test#2474
ozhuraki wants to merge 1 commit intokubernetes-sigs:masterfrom
ozhuraki:kubectl-nfd-nfg

Conversation

@ozhuraki
Copy link
Copy Markdown
Contributor

@ozhuraki ozhuraki commented Mar 30, 2026

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 30, 2026 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 0734b8f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-nfd/deploys/69df9b7cc6425300082f4aa2
😎 Deploy Preview https://deploy-preview-2474--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 30, 2026

Hi @ozhuraki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 30, 2026
marquiz
marquiz reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @ArangoGutierrez

Comment thread cmd/kubectl-nfd/subcmd/dryrun.go Outdated
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ozhuraki
Once this PR has been reviewed and has the lgtm label, please ask for approval from arangogutierrez. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozhuraki ozhuraki requested a review from marquiz April 2, 2026 11:38
marquiz
marquiz reviewed Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ozhuraki my review was a bit too concise. What I tried to say, don't add new commanline flags, just detect what type of object (NFR or NFG or if something else, error out) was given, probably renaming the longname of the flag to something more generic

@ozhuraki
Copy link
Copy Markdown
Contributor Author

ozhuraki commented Apr 5, 2026

@marquiz Thanks, done. PTAL.

@ozhuraki ozhuraki requested a review from marquiz April 5, 2026 20:53
marquiz
marquiz reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @ozhuraki, looks quite good. Some further suggestions below

Comment thread pkg/kubectl-nfd/validate.go Outdated
Comment thread pkg/kubectl-nfd/validate.go Outdated
Comment thread pkg/kubectl-nfd/test.go Outdated
Comment thread cmd/kubectl-nfd/subcmd/dryrun.go Outdated
Comment thread cmd/kubectl-nfd/subcmd/dryrun.go Outdated
@ozhuraki
kubectl-nfd: Add NodeFeatureGroup dryrun, validation and test
0734b8f 
Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
@ozhuraki
Copy link
Copy Markdown
Contributor Author

ozhuraki commented Apr 14, 2026

@marquiz Thanks for the help. Done, PTAL.

@ozhuraki ozhuraki requested a review from marquiz April 14, 2026 13:21
marquiz
marquiz reviewed Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ozhuraki looks pretty clean to me. One small wish below

Comment thread pkg/kubectl-nfd/validate.go Outdated
@marquiz
Copy link
Copy Markdown
Contributor

marquiz commented Apr 15, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2026
@ozhuraki
Copy link
Copy Markdown
Contributor Author

ozhuraki commented Apr 15, 2026

@marquiz Thanks, done, PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marquiz marquiz marquiz left review comments

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

Assignees

@ArangoGutierrez ArangoGutierrez

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ozhuraki @k8s-ci-robot @marquiz @ArangoGutierrez