Skip to content

[release-0.18] nfd-master: fix panic on NodeFeature delete #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Apr 10, 2026
+24 −2
Merged

[release-0.18] nfd-master: fix panic on NodeFeature delete #2487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions pkg/nfd-master/nfd-api-controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,18 @@ func newNfdController(config *restclient.Config, nfdApiControllerOptions nfdApiC
}
},
DeleteFunc: func(obj interface{}) {
nfr := obj.(*nfdv1alpha1.NodeFeature)
// obj may be a DeletedFinalStateUnknown if the watch was missed
if deletedFinalStateUnknown, ok := obj.(cache.DeletedFinalStateUnknown); ok {
klog.V(2).InfoS("found stale NodeFeature object", "object", obj)
obj = deletedFinalStateUnknown.Obj
}

nfr, ok := obj.(*nfdv1alpha1.NodeFeature)
if !ok {
klog.ErrorS(fmt.Errorf("unexpected object type %T", obj), "cannot convert object to NodeFeature")
return
}

klog.V(2).InfoS("NodeFeature deleted", "nodefeature", klog.KObj(nfr))
c.updateOneNode("NodeFeature", nfr)
if !nfdApiControllerOptions.DisableNodeFeatureGroup {
Expand Down Expand Up @@ -179,7 +190,18 @@ func newNfdController(config *restclient.Config, nfdApiControllerOptions nfdApiC
c.updateNodeFeatureGroup(nfg.Name)
},
DeleteFunc: func(obj interface{}) {
nfg := obj.(*nfdv1alpha1.NodeFeatureGroup)
// obj may be a DeletedFinalStateUnknown if the watch was missed
if deletedFinalStateUnknown, ok := obj.(cache.DeletedFinalStateUnknown); ok {
klog.V(2).InfoS("found stale NodeFeatureGroup object", "object", obj)
obj = deletedFinalStateUnknown.Obj
}

nfg, ok := obj.(*nfdv1alpha1.NodeFeatureGroup)
if !ok {
klog.ErrorS(fmt.Errorf("unexpected object type %T", obj), "cannot convert object to NodeFeatureGroup")
return
}

klog.V(2).InfoS("NodeFeatureGroup deleted", "nodeFeatureGroup", klog.KObj(nfg))
c.updateNodeFeatureGroup(nfg.Name)
},
Expand Down