OCPBUGS-62730 - Fixed typos and truncated field values in JSON audit logs generated by the JSON enricher#3071
Conversation
|
Hi @BhargaviGudi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BhargaviGudi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3071 +/- ##
===========================================
- Coverage 45.50% 24.26% -21.24%
===========================================
Files 79 125 +46
Lines 7782 17776 +9994
===========================================
+ Hits 3541 4313 +772
- Misses 4099 13176 +9077
- Partials 142 287 +145 🚀 New features to boost your workflow:
|
81e7e67 to
224b145
Compare
|
/ok-to-test |
006a556 to
9d57d22
Compare
|
@ngopalak-redhat Could you please help me review the PR? Thanks |
|
/retitle OCPBUGS-62730: Fixed typos and truncated field values in JSON audit logs generated by the JSON enricher |
|
@BhargaviGudi: Re-titling can only be requested by trusted users, like repository collaborators. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
resolved format issue Updated proper synchronization for the LogBucket Resolved go-lint issues revert nodeNameCopy := nodeName
9d57d22 to
43a5e54
Compare
|
/verified |
|
/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-baremetalds-ipi-ovn-lvms-f14-security-profiles |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes typos and truncated field values in the JSON audit logs generated by the Security Profiles Operator's JSON enricher. The issue manifested as:
Changes:
podName,namespace, andcontainerNamefromContainerInfointo local variables before assigning to the resource mapnodeNamebefore assigning to the node mapThis ensures all JSON keys and values in audit logs are correctly spelled and complete.
Which issue(s) this PR fixes:
Fixes OCPBUGS-62730
Does this PR have test?
Tested manually to verify the values
test result:
With this fix, all field names and values are now complete and correctly spelled.
Special notes for your reviewer:
The fix is minimal and surgical - by copying string values to local variables before map assignment, we prevent the memory corruption that was causing character truncation and field name typos. This is a critical fix for audit log reliability and automated log processing.
Does this PR introduce a user-facing change?