Skip to content

Remove apt.llvm.org dependency in verify job; use distro clang-format#3126

Closed
sasmita016 wants to merge 2 commits intokubernetes-sigs:mainfrom
sasmita016:fix-llvm-trixie-verify
Closed

Remove apt.llvm.org dependency in verify job; use distro clang-format#3126
sasmita016 wants to merge 2 commits intokubernetes-sigs:mainfrom
sasmita016:fix-llvm-trixie-verify

Conversation

@sasmita016
Copy link
Copy Markdown

@sasmita016 sasmita016 commented Mar 30, 2026

Remove apt.llvm.org dependency in verify job; use distro clang-format

The verify script installs LLVM/Clang 21 via apt.llvm.org, which is currently failing on Debian Trixie due to apt signature (SHA1) restrictions.

Since the script only requires clang-format before running make verify, replace the external LLVM install with the distro-provided clang-format.

This removes the failing dependency while preserving the intended behavior.

Fixes: kubernetes/kubernetes#137097

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 30, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sasmita016
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @sasmita016!

It looks like this is your first PR to kubernetes-sigs/security-profiles-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/security-profiles-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from Vincent056 March 30, 2026 07:29
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 30, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @sasmita016. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 30, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.64%. Comparing base (11d77f4) to head (7b95438).
⚠️ Report is 1118 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3126       +/-   ##
===========================================
- Coverage   45.50%   24.64%   -20.86%     
===========================================
  Files          79      126       +47     
  Lines        7782    17992    +10210     
===========================================
+ Hits         3541     4435      +894     
- Misses       4099    13265     +9166     
- Partials      142      292      +150     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saschagrunert
Copy link
Copy Markdown
Member

The build / bpf error is unrelated.

@saschagrunert
Copy link
Copy Markdown
Member

/release-note-none
/ok-to-test

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@sasmita016: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-security-profiles-operator-verify 7b95438 link true /test pull-security-profiles-operator-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@saschagrunert
Copy link
Copy Markdown
Member

pull-security-profiles-operator-verify fails.

hack/tree-status
tree is clean
curl -sSfL -o build/zeitgeist \
	https://storage.googleapis.com/k8s-artifacts-sig-release/kubernetes-sigs/zeitgeist/v0.5.4/zeitgeist-amd64-linux
chmod +x build/zeitgeist
build/zeitgeist validate --local-only --base-path . --config dependencies.yaml
level=error msg="dependencies.yaml indicates that clang-ci should be at version 21, but the following files didn't match: hack/pull-security-profiles-operator-verify"
level=fatal msg="error during command execution: &fmt.wrapError{msg:\"checking local dependencies: Dependencies are not in sync\", err:(*errors.errorString)(0xc000235790)}"
make: *** [Makefile:467: verify-dependencies] Error 1

@saschagrunert
Copy link
Copy Markdown
Member

I guess this is needed, feel free to reopen if I'm missing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Failing Test][SIG Node] pull-security-profiles-operator-verify failing

4 participants