Add (*Set).FromJSON benchmarks and switch to post-accumulation sort.#310
Open
benluddy wants to merge 1 commit into
Open
Add (*Set).FromJSON benchmarks and switch to post-accumulation sort.#310benluddy wants to merge 1 commit into
benluddy wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
Contributor
Author
liggitt
reviewed
Dec 19, 2025
benluddy
force-pushed
the
fromjson-post-accumulation-sort
branch
from
December 19, 2025 15:58
6c869cc to
367149b
Compare
k8s-ci-robot
added
size/L
Set deserialization with children in reverse order performs an insertion sort. Sets serialized by
structured-merge-diff are sorted, but in practice the serialization of sets is controlled by clients
and they can (intentionally or not) exercise this worst case. Switching to a bulk insert followed by
a sort appears to perform no worse in the best case (sorted) and is significantly better in the
worst case:
│ master │ bulk │
│ sec/op │ sec/op vs base │
SetFromJSON/children_in_ascending_order 1.286m ± 3% 1.341m ± 1% +4.27% (p=0.000 n=10)
SetFromJSON/children_in_descending_order 20.189m ± 0% 1.385m ± 1% -93.14% (p=0.000 n=10)
SetFromJSON/grandchildren_in_ascending_order 7.821m ± 1% 8.211m ± 1% +4.98% (p=0.000 n=10)
SetFromJSON/grandchildren_in_descending_order 75.16m ± 4% 13.31m ± 13% -82.28% (p=0.000 n=10)
geomean 11.11m 3.774m -66.04%
│ master │ bulk │
│ B/op │ B/op vs base │
SetFromJSON/children_in_ascending_order 1.320Mi ± 0% 1.320Mi ± 0% ~ (p=1.000 n=10)
SetFromJSON/children_in_descending_order 1.320Mi ± 0% 1.320Mi ± 0% +0.00% (p=0.000 n=10)
SetFromJSON/grandchildren_in_ascending_order 5.395Mi ± 0% 5.395Mi ± 0% +0.00% (p=0.000 n=10)
SetFromJSON/grandchildren_in_descending_order 6.187Mi ± 0% 5.395Mi ± 0% -12.80% (p=0.000 n=10)
geomean 2.761Mi 2.668Mi -3.37%
│ master │ bulk │
│ allocs/op │ allocs/op vs base │
SetFromJSON/children_in_ascending_order 25.99k ± 0% 25.99k ± 0% ~ (p=1.000 n=10) ¹
SetFromJSON/children_in_descending_order 25.99k ± 0% 25.99k ± 0% ~ (p=1.000 n=10) ¹
SetFromJSON/grandchildren_in_ascending_order 138.4k ± 0% 138.4k ± 0% ~ (p=1.000 n=10) ¹
SetFromJSON/grandchildren_in_descending_order 155.7k ± 0% 138.4k ± 0% -11.11% (p=0.000 n=10)
geomean 61.77k 59.98k -2.90%
¹ all samples are equal
benluddy
force-pushed
the
fromjson-post-accumulation-sort
branch
from
December 19, 2025 16:05
367149b to
26509bc
Compare
Contributor
|
cc @jpbetz for detailed review |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
Member
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
kubernetes-prow
Bot
added
the
lifecycle/stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set deserialization with children in reverse order performs an insertion sort. Sets serialized by structured-merge-diff are sorted, but in practice the serialization of sets is controlled by clients and they can (intentionally or not) exercise this worst case. Switching to a bulk insert followed by a sort appears to perform no worse in the best case (sorted) and is significantly better in the worst case:
This was originally proposed in #292. All I've done here is added benchmarks to demonstrate the worst case performance and separated it from the json-iterator migration.