Skip to content

Replace update api invocations with patch api#3893

Open
chethanv28 wants to merge 1 commit into
kubernetes-sigs:masterfrom
chethanv28:topic/chethanv28/replace-update-with-patch-misc
Open

Replace update api invocations with patch api#3893
chethanv28 wants to merge 1 commit into
kubernetes-sigs:masterfrom
chethanv28:topic/chethanv28/replace-update-with-patch-misc

Conversation

@chethanv28
Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Replace update api invocations with patch api for multiple api resources & for the following files:

PersistentVolumeClaim (annotations)	                               pkg/syncer/fullsync.go
PersistentVolumeClaim (finalizer)	                             pkg/syncer/fullsync.go
VolumeSnapshot (finalizer)	pkg/syncer/fullsync.go
PersistentVolumeClaim (health annotation)	pkg/syncer/volume_health.go
PersistentVolumeClaim (health annotation retry)	pkg/syncer/volume_health.go
PersistentVolumeClaim (backing disk annotation)	pkg/syncer/pv_to_backingdiskobjectid_mapping.go
PersistentVolumeClaim (backing disk annotation retry)	pkg/syncer/pv_to_backingdiskobjectid_mapping.go
StoragePool	pkg/syncer/storagepool/intended_state.go
CnsFileVolumeClient	pkg/syncer/metadatasyncer.go
CnsFileVolumeClient	pkg/internalapis/cnsoperator/cnsfilevolumeclient/cnsfilevolumeclient.go
CnsFileVolumeClient	pkg/internalapis/cnsoperator/cnsfilevolumeclient/cnsfilevolumeclient.go
CnsFileVolumeClient	pkg/internalapis/cnsoperator/cnsfilevolumeclient/cnsfilevolumeclient.go
CnsVolumeOperationRequest	pkg/internalapis/cnsvolumeoperationrequest/cnsvolumeoperationrequest.go
CnsRegisterVolume	pkg/syncer/cnsoperator/controller/cnsregistervolume/cnsregistervolume_controller.go
CnsUnregisterVolume	pkg/syncer/cnsoperator/controller/cnsunregistervolume/controller.go
CnsUnregisterVolume	pkg/syncer/cnsoperator/controller/cnsunregistervolume/controller.go
CnsNodeVmAttachment	pkg/syncer/cnsoperator/controller/cnsnodevmattachment/cnsnodevmattachment_controller.go
CnsNodeVmAttachment	pkg/syncer/cnsoperator/controller/cnsnodevmattachment/cnsnodevmattachment_controller.go
CnsNodeVMBatchAttachment Status	pkg/syncer/cnsoperator/controller/cnsnodevmbatchattachment/cnsnodevmbatchattachment_helper.go
PersistentVolume	pkg/kubernetes/kubernetes.go
PersistentVolumeClaim	pkg/kubernetes/kubernetes.go
PersistentVolumeClaim	pkg/kubernetes/kubernetes.go
ConfigMap	pkg/csi/service/common/commonco/k8sorchestrator/k8sorchestrator.go
PersistentVolume	pkg/csi/service/common/commonco/k8sorchestrator/k8sorchestrator.go
PersistentVolumeClaim	pkg/csi/service/common/commonco/k8sorchestrator/k8sorchestrator.go
PersistentVolumeClaim	pkg/csi/service/common/commonco/k8sorchestrator/k8sorchestrator_helper.go
CustomResourceDefinition	pkg/kubernetes/kubernetes.go
Generic Object (with finalizer)	pkg/kubernetes/kubernetes.go
Generic Object (remove finalizer)	pkg/kubernetes/kubernetes.go
Generic Object Status	pkg/kubernetes/kubernetes.go

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
TBA

Special notes for your reviewer:

Release note:

Replace update api invocations with patch api

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from gnufied February 9, 2026 23:45
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 9, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@chethanv28: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-vsphere-csi-driver-verify-fmt a6cc461 link true /test pull-vsphere-csi-driver-verify-fmt
pull-vsphere-csi-driver-verify-golangci-lint a6cc461 link true /test pull-vsphere-csi-driver-verify-golangci-lint
pull-vsphere-csi-driver-unit-test a6cc461 link true /test pull-vsphere-csi-driver-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link
Copy Markdown

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants