Update Supervisor deployment yaml to install csi snapshot metadata service as a part of CSI controller, starting k8s v1.33#3933
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akankshapanse The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b0b216a to
776fb8a
Compare
9300e8a to
01f079f
Compare
|
Can you run the pipeline? |
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
01f079f to
2de4a9c
Compare
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
FAILED --- Jenkins Build #1163 |
2de4a9c to
00a156d
Compare
00a156d to
75cd2b9
Compare
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
FAILED --- Jenkins Build #1194 |
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
FAILED --- Jenkins Build #1202 |
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
FAILED --- Jenkins Build #1203 |
I tried to run CSI precheckin pipelines, however pipelines today require instapp setup and these setups/pipelines do not have parameter to take FSS/capability as input. So the changes cannot be tested with CSI precheckin pipeline. |
|
SUCCESS --- Jenkins Build #1206 |
75cd2b9 to
52b027b
Compare
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
FAILED --- Jenkins Build #1265 |
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
FAILED --- Jenkins Build #1267 |
|
FAILED --- Jenkins Build #1266 |
a275bca to
4d33cb9
Compare
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
FAILED --- Jenkins Build #1271 |
4d33cb9 to
75afffc
Compare
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
75afffc to
fcd2aea
Compare
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
fcd2aea to
4f73e7b
Compare
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
…rvice as a part of CSI controller, starting k8s v1.33 + Install SnapshotMetadataService CR temporarily via syncer code based on FSS check(TO be removed after FSS enabled)
4f73e7b to
dfa72ec
Compare
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
FAILED --- Jenkins Build #1275 |
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
|
FAILED --- Jenkins Build #1280 |
|
FAILED --- Jenkins Build #1279 |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
closing this as it will be handled in supervisor installation till the fss is disabled |
What this PR does / why we need it:
Starting K8s 1.33, we will support CSI CBT feature, which exposes CBT metadata from storage backend to clients running in K8s cluster. This PR adds changes to deploy vSphere csi snapshot metadata service as a part of CSI controller pod.
With these changes, following components get deployed as a part of cns-csi.yaml
Additionally, there will be new SnapshotMetadataService CR "vsphere-csi-snapshot-metadata", exposing vSphere snapshot metadata service and related data, deployed on syncer startup, if FSS enabled. CRD for this CR will be installed as a part of Supervisor cluster (Similar to snapshot related CRDs), if FSS is enabled.
NOTE: CR install in syncer is a temporary change to test change with precheckin pipelines without any FSS and functionality enabled. Once the FSS is enabled, this CR can be added to cns-csi.yaml for default deployment.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Testing done:
Tested changes with some additional changes for CRD deployment by creating a setup
Verified changes do not install components on v1.32.X supervisor cluster
Special notes for your reviewer:
Release note: