Address review feedback from kayrus

- Remove duplicate clusterUID field from the OpenStack struct so the
  identifier lives only on the LoadBalancer struct that actually uses it
  (better cohesion).
- Drop fetchClusterUID() out of Initialize() and call it lazily inside
  the LoadBalancer() factory instead. Clusters that disable LB now skip
  the kube-system namespace lookup entirely, and the change touches only
  the LB construction path.
- Remove the unused eventLBStolen constant. It was a leftover from an
  earlier draft that intended to emit a Warning event from
  getLoadbalancerByName(); plumbing the eventRecorder + *v1.Service into
  that free-standing function felt out of scope, so the emission was
  dropped but the constant was left behind.

Author: enginrect

pkg/openstack/loadbalancer.go

@@ -112,12 +112,6 @@ const (
 	// OCCM to disambiguate load balancers when multiple Kubernetes clusters
 	// share the same OpenStack project and a service name happens to collide.
 	clusterIDTagPrefix = "kube_cluster_id_"
-
-	// eventLBStolen is emitted when getLoadbalancerByName finds a load
-	// balancer with a matching name that belongs to a different Kubernetes
-	// cluster (different cluster-id tag). The lookup is treated as NotFound
-	// so OCCM creates a new load balancer instead of stealing an existing one.
-	eventLBStolen = "LoadBalancerNameCollision"
 )
 
 // clusterIDTag formats the Octavia load balancer tag carrying the cluster

pkg/openstack/openstack.go

@@ -167,11 +167,6 @@ type OpenStack struct {
 	kclient               kubernetes.Interface
 	nodeInformer          coreinformers.NodeInformer
 	nodeInformerHasSynced func() bool
-	// clusterUID is the kube-system namespace UID, used as a stable cluster
-	// identifier on OpenStack load balancer tags. May be empty if the lookup
-	// failed or RBAC does not allow it; in that case OCCM falls back to the
-	// legacy name-based load balancer identification.
-	clusterUID string
 
 	eventBroadcaster record.EventBroadcaster
 	eventRecorder    record.EventRecorder
@@ -211,7 +206,6 @@ func (os *OpenStack) Initialize(clientBuilder cloudprovider.ControllerClientBuil
 	os.eventBroadcaster = record.NewBroadcaster()
 	os.eventBroadcaster.StartRecordingToSink(&v1core.EventSinkImpl{Interface: os.kclient.CoreV1().Events("")})
 	os.eventRecorder = os.eventBroadcaster.NewRecorder(scheme.Scheme, v1.EventSource{Component: "cloud-provider-openstack"})
-	os.clusterUID = fetchClusterUID(clientset)
 }
 
 // fetchClusterUID returns the UID of the kube-system namespace, which is a
@@ -405,7 +399,8 @@ func (os *OpenStack) LoadBalancer() (cloudprovider.LoadBalancer, bool) {
 
 	klog.V(1).Info("Claiming to support LoadBalancer")
 
-	return &LbaasV2{LoadBalancer{secret, network, lb, os.lbOpts, os.kclient, os.eventRecorder, os.clusterUID}}, true
+	clusterUID := fetchClusterUID(os.kclient)
+	return &LbaasV2{LoadBalancer{secret, network, lb, os.lbOpts, os.kclient, os.eventRecorder, clusterUID}}, true
 }
 
 // Zones indicates that we support zones