[cinder-csi-plugin] Fix ControllerGetVolume multi-cloud iteration bug (#3121)

hemna · web-flow · commit a01095060624 · 2026-06-06T17:12:31.000+05:30
In ControllerGetVolume, when multiple clouds are configured, the loop
iterates over all clouds without breaking on success. If the volume is
found in an earlier cloud but a subsequent cloud returns NotFound, the
err variable is overwritten and the function erroneously returns
NotFound despite having already located the volume.

Add a break statement after a successful GetVolume call to stop
iterating once the volume is found.

Signed-off-by: Walter Boring &lt;waboring@hemna.com&gt;
diff --git a/pkg/csi/cinder/controllerserver.go b/pkg/csi/cinder/controllerserver.go
@@ -952,6 +952,7 @@ func (cs *controllerServer) ControllerGetVolume(ctx context.Context, req *csi.Co
 			}
 			return nil, status.Errorf(codes.Internal, "ControllerGetVolume failed with error %v", err)
 		}
+		break
 	}
 	if err != nil {
 		return nil, status.Errorf(codes.NotFound, "Volume %s not found", volumeID)

Original file line number	Diff line number	Diff line change
`@@ -952,6 +952,7 @@ func (cs controllerServer) ControllerGetVolume(ctx context.Context, req csi.Co`
`952`	`952`	`}`
`953`	`953`	`return nil, status.Errorf(codes.Internal, "ControllerGetVolume failed with error %v", err)`
`954`	`954`	`}`
	`955`	`+ break`
`955`	`956`	`}`
`956`	`957`	`if err != nil {`
`957`	`958`	`return nil, status.Errorf(codes.NotFound, "Volume %s not found", volumeID)`