Skip to content

Commit b9be0f4

Browse files
committed
code review
1 parent cd1254b commit b9be0f4

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

charts/cinder-csi-plugin/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v1
22
appVersion: v1.32.0
33
description: Cinder CSI Chart for OpenStack
44
name: openstack-cinder-csi
5-
version: 2.33.0-alpha.0
5+
version: 2.33.0-alpha.1
66
home: https://github.com/kubernetes/cloud-provider-openstack
77
icon: https://github.com/kubernetes/kubernetes/blob/master/logo/logo.png
88
maintainers:

docs/cinder-csi-plugin/multi-region-clouds.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -318,15 +318,15 @@ spec:
318318
...
319319
```
320320

321-
### When using the cinder-csi-plugin helmchart
321+
### When Using the cinder-csi-plugin Helm Chart
322322

323-
When runing the cinder-csi-plugin with multi-region, you need to specify different `extraArgs` on the `cinder-csi-plugin` containers of the deployment and the daemonset.
323+
When running the `cinder-csi-plugin` in a multi-region setup, you need to specify different `extraArgs` for the `cinder-csi-plugin` containers in both the Deployment and the DaemonSet.
324324

325-
When using the helmchart, you need to set the different `extraArgs` on `plugin.nodePlugin.extraArgs` and `plugin.controllerPlugin.extraArgs`.
325+
When using the Helm chart, set the different `extraArgs` using `plugin.nodePlugin.extraArgs` and `plugin.controllerPlugin.extraArgs`.
326326

327-
If you set the extraArgs in `plugin.extraArgs`, the same `extraArgs` will end up on both the `cinder-csi-plugin` container of both the deployment and the daemonset.
327+
If you set the `extraArgs` in `plugin.extraArgs`, the same arguments will be applied to both the Deployment and the DaemonSet `cinder-csi-plugin` containers.
328328

329-
You will still need to manually create your additionnal daemonsets for your additionnal regions.
329+
You will still need to manually create additional DaemonSets for your extra regions.
330330

331331
```yaml
332332
nodePlugin:
@@ -340,7 +340,7 @@ controllerPlugin:
340340
- --cloud-name=region-two
341341
```
342342

343-
In addition, if you use the `resizer` and the `snapshotter`, you will need them to be able to read the secrets you defined in the storage class' annotations in order to determine which cloud to address. You will need to add some `extraRbac` in YAML format, like this:
343+
In addition, if you use the `resizer` and the `snapshotter`, you will need them to be able to read the secrets you defined in the storage class' annotations in order to determine which cloud to address. You will need to add some `extraRbac` in YAML format, like this:
344344

345345
```yaml
346346
snapshotter:
@@ -353,4 +353,4 @@ resizer:
353353
- apiGroups: [""]
354354
resources: ["secrets"]
355355
verbs: ["get", "list", "watch"]
356-
```
356+
```

0 commit comments

Comments
 (0)