Skip to content

[occm] Fix serviceMonitor labelSelector and remove deprecated bearerT…#3040

Closed
claudia-lola wants to merge 1 commit into
kubernetes:masterfrom
claudia-lola:occm
Closed

[occm] Fix serviceMonitor labelSelector and remove deprecated bearerT…#3040
claudia-lola wants to merge 1 commit into
kubernetes:masterfrom
claudia-lola:occm

Conversation

@claudia-lola

Copy link
Copy Markdown

…okenFile auth

What this PR does / why we need it:
The labels on the Service did not match the ServiceMonitor selector. Prometheus was unable to discover the target. This change sets the labels so the ServiceMonitor selects the correct Service.
bearerTokenFile is deprecated and no longer works. ServiceMonitor was updated to use a supported authentication method.
authorization-always-allow-paths="/metrics" was added to ensure metrics can be scraped.

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 14, 2026
@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @claudia-lola. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants