fix: normalize underscores to dashes in Service metadata.name

[vigneshakaviki]

Summary

Fixes #1897

When a Docker Compose service name contains underscores (e.g., my_web_app), kompose correctly normalizes the map key and most resource names to use dashes (my-web-app), but the serviceConfig.Name field retains underscores because it's set via parseResourceName() which uses normalizeContainerNames() (lowercase only, no underscore replacement).

This causes the Kubernetes Service metadata.name to contain underscores (my_web_app) while other resources like Deployments correctly use dashes (my-web-app).

Root Cause

In dockerComposeToKomposeMapping(), serviceConfig.Name is initially set from parseResourceName() which calls normalizeContainerNames(). The map key is set from normalizeServiceNames() (which replaces underscores with dashes), but serviceConfig.Name is never updated to match.

Fix

Set serviceConfig.Name to the result of normalizeServiceNames() so all generated Kubernetes resources use consistent, DNS-valid names.

Before (stock kompose)

$ kompose convert -f docker-compose.yaml --stdout
# Service gets: name: my_web_app    ← invalid, has underscores
# Deployment gets: name: my-web-app ← correct

After (patched)

$ kompose convert -f docker-compose.yaml --stdout
# Service gets: name: my-web-app    ← correct
# Deployment gets: name: my-web-app ← correct

Test Plan

• Added TestServiceConfigNameNormalized unit test that:
  • Creates a compose project with service name my_service
  • Verifies serviceConfig.Name is my-service after mapping
  • Confirmed test fails without the fix, passes with it
• All existing tests pass (go test ./...)
• End-to-end verification with kompose convert --stdout

[k8s-ci-robot]

Invalid commit message issues detected

Invalid commit messages

Keywords which can automatically close issues and hashtag(#) mentions are not allowed.

• 58c0465 fix: normalize service name with dashes in serviceConfig.Name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @vigneshakaviki!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vigneshakaviki
Once this PR has been reviewed and has the lgtm label, please assign cdrage for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cdrage]

Hi @vigneshakaviki the main blocker would be the commit message, any way you can modify it to pass? :) thanks